Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed failures when I tried to run
./build/gen_stub.php --verify-manual ./ ../doc-en/
, and it turned out that the newly added ext/dom constant aliases cause this. I found no way to add support for theDOM_INDEX_SIZE_ERR / Dom\INDEX_SIZE_ERR
format in gen_stub.php (gen_stub.php can only replace/fix constants one-by-one), so I had to duplicate the constant definitions in the manual.Since the constant IDs would clash in most of the cases, I had to add an extra
dom-
prefix to them. It may be possible to fix these via phd and use.
as separator instead of-
in case of namespaces (?).