Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/urlfsmappings #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mrmiagi
Copy link

@mrmiagi mrmiagi commented Mar 20, 2013

Added a setting that allows to define a mapping of urls to file system paths

@pilif
Copy link
Owner

pilif commented Mar 20, 2013

Very cool idea. Thanks a lot.

I added a few comments to one of the commits and I would love if you could take the time to maybe have a look at it.

Also, is this enough? When you have a static.example.com, then smarty's way of just emitting a path relative to the current host won't be enough - at least you'd use the main advantage of a static.-domain (no cookies being sent).

IMHO, this also (and maybe you can get away with only instead of also) a way to tell sacy to prefix the emitted URL with a different host.

so something like

define('SACY_STATIC_HOST_PREFIX', 'http://static.example.com/');

which would then have sacy generate

<script src="http://static.example.com/assets/many-files-344deadbeef.js"></script>

instead of just

<script src="/assets/many-files-344deadbeef.js"></script>

I'm about to need something like this anyways in my setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants