Refactor sparse vector integration tests #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We had a ticket logged for making sure that we covered working with sparse vectors in integration tests.
Solution
I realized we were already creating sparse vectors whenever we called
createVectorsForUpsert
, but the function was a bit unwieldy to work with.I refactored things into a new helper
func GenerateVectors(numOfVectors int, dimension int32, isSparse bool) []*Vector
. This is a bit more flexible.I also cleaned up how we were handling the
IntegrationTest.vectorIds
field on the test struct. I wanted to make sure we were consistently adding to and deleting from this collection across tests.Type of Change
Test Plan
Existing integration tests should pass.