Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bulk Import, Regenerate core for 2024-10 API #79

Merged
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e225c56
regenerate client code from 2024-10 specification, update build-clien…
austin-denoble Oct 10, 2024
2ad000f
update IndexConnection and Client to support adding the REST implemen…
austin-denoble Oct 10, 2024
06a4397
regenerate code from spec changes, implement bulk import start, cance…
austin-denoble Oct 12, 2024
67a2fa5
run just gen off latest spec changes
austin-denoble Oct 14, 2024
69be1f8
clean up build-clients.sh comments
austin-denoble Oct 14, 2024
bde3e30
add custom types for import operations toFoo() functions for handling…
austin-denoble Oct 15, 2024
27de308
fix test file
austin-denoble Oct 15, 2024
fc1911b
standardize the import names for different modules
austin-denoble Oct 15, 2024
28356bf
clean up comments
austin-denoble Oct 15, 2024
8c0d9fc
more tweaks to imports, add doc comments for all new import operation…
austin-denoble Oct 15, 2024
f6b3841
get rid of failing the test suite on teardown
austin-denoble Oct 15, 2024
281a5ad
fix nil pointer reference on StartImport op
austin-denoble Oct 15, 2024
5a7b2df
remove continue-on-error for tests step
austin-denoble Oct 15, 2024
1a21bab
fix nil pointer reference again
austin-denoble Oct 15, 2024
7b53f93
make sure MetadataFilter is public on QueryByVectorIdRequest
austin-denoble Oct 15, 2024
616675e
review feedback - tweak doc comments, link to specific code bits
austin-denoble Oct 16, 2024
9e85a0a
add error test for no uri when calling StartImport
austin-denoble Oct 16, 2024
5951a3d
swap schema -> scheme
austin-denoble Oct 16, 2024
13ae2c7
add small retry mechanism for integration test cleanup when deletion …
austin-denoble Oct 16, 2024
1456a4b
fix logic in retry
austin-denoble Oct 16, 2024
e7ea5f9
try and fix the update vector metadata flakiness
austin-denoble Oct 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ jobs:
run: |
go get ./pinecone
- name: Run tests
continue-on-error: true
run: go test -count=1 -v ./pinecone
env:
PINECONE_API_KEY: ${{ secrets.API_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion codegen/apis
Submodule apis updated from 3b7369 to 3002f1
17 changes: 13 additions & 4 deletions codegen/build-clients.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@ db_control_module="db_control"
db_data_module="db_data"
inference_module="inference"

# generated output destination paths
# generated grpc output destination paths
# db_data_destination must align with the option go_package in the proto file:
# https://github.com/pinecone-io/apis/blob/d1d005e75cc9fe9a5c486ef9218fe87b57765961/src/release/db/data/data.proto#L3
db_data_destination="internal/gen/data"
db_data_destination="internal/gen/${db_data_module}"
db_control_destination="internal/gen/${db_control_module}"
inference_destination="internal/gen/${inference_module}"

# version file
version_file="internal/gen/api_version.go"
# generated oas files

# generated oas file destination paths
db_data_rest_destination="${db_data_destination}/rest"
db_data_oas_file="${db_data_rest_destination}/${db_data_module}_${version}.oas.go"
db_control_oas_file="${db_control_destination}/${db_control_module}_${version}.oas.go"
inference_oas_file="${inference_destination}/${inference_module}_${version}.oas.go"

Expand Down Expand Up @@ -92,6 +95,9 @@ EOL
update_apis_repo
verify_spec_version $version

# Clear internal/gen/* contents
rm -rf internal/gen/*

# Generate db_control oas client
rm -rf "${db_control_destination}"
mkdir -p "${db_control_destination}"
Expand All @@ -102,9 +108,12 @@ rm -rf "${inference_destination}"
mkdir -p "${inference_destination}"
generate_oas_client $inference_module $inference_oas_file

# Generate db_data proto client
# Generate db_data oas and proto clients
rm -rf "${db_data_destination}"
mkdir -p "${db_data_destination}"
mkdir -p "${db_data_rest_destination}"

generate_oas_client $db_data_module $db_data_oas_file
generate_proto_client $db_data_module

# Generate version file
Expand Down
Loading