Skip to content

Commit

Permalink
Remove extra call to delete an already-deleted index in bulkImport
Browse files Browse the repository at this point in the history
…integration test (#313)

## Problem

We kept getting errors in CI that part of the `bulkImport` integration
test was failing because it could not find the given index name.

## Solution

Turns out, we accidentally left in an extra call to `delete` after we
had already deleted the index! This PR just removes that call :)

## Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

## Test Plan

CI passes w/flying colors 🚀 

---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1208633891828391
  • Loading branch information
aulorbe authored Nov 1, 2024
1 parent 621384f commit 26d31d7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/integration/data/bulk/bulkImport.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ describe('bulk import', () => {

afterAll(async () => {
await retryDeletes(pinecone, indexName);
await pinecone.deleteIndex(indexName);
});

test('verify bulk import', async () => {
Expand Down

0 comments on commit 26d31d7

Please sign in to comment.