Skip to content

Commit

Permalink
Remove old jest-skipped-reporter module (#268)
Browse files Browse the repository at this point in the history
## Problem

When running `npm audit`, we had cascading vulnerabilities ranging in
severity due to our use of the `jest-skipped-reporter`
[module](https://github.com/rickhanlonii/jest-skipped-reporter). This
module hasn't been updated in 5 years, so we really shouldn't be
depending on it.

## Solution

Remove this module. It only reported skipped tests, which I don't think
is super necessary anyways.

## Npm Audit Results

Before (recreated by checking out `main`): 
<img width="1388" alt="Screenshot 2024-08-28 at 11 13 50 AM"
src="https://github.com/user-attachments/assets/76abc278-ee7d-49a2-8723-dfd5215a7671">
<img width="1387" alt="Screenshot 2024-08-28 at 11 13 55 AM"
src="https://github.com/user-attachments/assets/a780d15a-dc39-4403-a7e5-7ee9c65bc867">


After (ran on this PR's branch): 
<img width="620" alt="Screenshot 2024-08-28 at 11 13 20 AM"
src="https://github.com/user-attachments/assets/35a5500b-ede5-4a96-a8f9-d733381db40b">


## Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [x] Infrastructure change (CI configs, etc)
- [x] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

## Test Plan

CI passes.


---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1208058866322097
  • Loading branch information
aulorbe authored Aug 30, 2024
1 parent 515e9e3 commit 768cee0
Show file tree
Hide file tree
Showing 3 changed files with 370 additions and 2,189 deletions.
1 change: 0 additions & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ module.exports = {
reporters: [
['github-actions', { silent: false }],
'jest-progress-bar-reporter',
'jest-skipped-reporter',
],
setupFilesAfterEnv: ['./utils/globalUnitTestSetup.ts'],
transform: {
Expand Down
Loading

0 comments on commit 768cee0

Please sign in to comment.