Skip to content

Commit

Permalink
Update workflow names; remove commented code
Browse files Browse the repository at this point in the history
  • Loading branch information
aulorbe committed Aug 27, 2024
1 parent 4d55b8b commit d300a71
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 27 deletions.
25 changes: 0 additions & 25 deletions .github/actions/e2d-testing/edge/vercel-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,28 +80,3 @@ jobs:

- name: Deploy to Vercel
run: vercel deploy --scope=${{ secrets.VERCEL_TEAM_SCOPE }}

# todo: how to interact with vercel cli in ci?
# - name: Build Pinecone Vercel app
# run: |
# npm run build
# npm install -g pnpm
# pnpm setup
# source ~/.zshrc
# pnpm i -g vercel
# pnpm i
# vercel deploy --scope=${{ secrets.VERCEL_TEAM_SCOPE }}
# - name: Run Vercel app tests
# run: npm run test:e2e

# - name: Install playwright
# run: npm i playwright && npx playwright test
# env:
# BASE_URL: https://vercel.live/link/pinecone-rag-demo-4rrbeb03q-pinecone-io.vercel.app?via=deployment-domains-list-commit

# todo: figure out how to log into vercel while inside playwright
# todo: figure out how to override localhost in actual test file -- maybe just make your own?
# or don't? because we don't care about the ui...

# - name: Hit endpoints
# run: npx hitVercelAppEndpoints.ts # tsc? need tsconfig.json etc?
4 changes: 2 additions & 2 deletions .github/workflows/e2e-testing.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Testing
name: End to end testing

on:
workflow_call: {}
Expand All @@ -11,5 +11,5 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Setup
- name: Run test
uses: ./.github/actions/e2d-testing/edge/vercel-deploy.yml

0 comments on commit d300a71

Please sign in to comment.