Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e external app test #326

Merged
merged 17 commits into from
Jan 24, 2025

Conversation

austin-denoble
Copy link
Contributor

@austin-denoble austin-denoble commented Jan 22, 2025

Problem

Test is currently failing in CI, but not locally. Need to investigate a bit from both ends.

Solution

  • Move ts-external-app-test out of src/ to the top level of the repo.
  • Improve some of the scripting in the external-app action and testing workflow - we were seeing failures even if the test itself was successful. Seemed like issues with grep'ing and trying to assert on things.
  • Minor cleanup.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

workflow

@austin-denoble austin-denoble force-pushed the release-candidate/2025-01 branch from 700bdf6 to 9143308 Compare January 23, 2025 15:41
@austin-denoble austin-denoble force-pushed the adenoble/fix-external-app branch from 1a45dfa to c5ad219 Compare January 23, 2025 17:29
@austin-denoble austin-denoble merged commit e8e60fa into release-candidate/2025-01 Jan 24, 2025
30 checks passed
@austin-denoble austin-denoble deleted the adenoble/fix-external-app branch January 24, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant