FIX: use default parameters #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugant
requested changes
Oct 20, 2016
| var parameters = {}; | ||
| var arg; | ||
|
|
||
| api(path, method = 'GET', parameters = {}) { |
There was a problem hiding this comment.
It's not 100% correct. For example, if I call api('/me', {'foo': 'bar'}) it would issue a call to the Facebook API with GET method and parameters {'foo': 'bar'}
There was a problem hiding this comment.
Default parameters? I didn't even know they exist in JS: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters
| method = arguments[1]; | ||
| parameters = arguments[2]; | ||
| } | ||
|
|
||
| parameters = Ember.$.extend(parameters, {access_token: this.accessToken}); |
There was a problem hiding this comment.
Ember.assign might be a better option here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.