Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clearCache, clearCacheAll and getAllKeys #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nkmrh
Copy link
Collaborator

@nkmrh nkmrh commented Oct 28, 2024

Summary

Implementation

下記メソッドを実装しました

  • clearCache
  • clearCacheAll
  • getAllKeys

Test plan

example project で動作確認をいたしました

Simulator.Screen.Recording.-.iPhone.15.-.2024-10-29.at.07.23.52.mp4

(clearCache, clearCacheAll の動作)

(getAllKeys の動作)

Other Information

@nkmrh nkmrh self-assigned this Oct 28, 2024
@nkmrh nkmrh requested a review from harukitosa October 28, 2024 22:28
Copy link

@harukitosa harukitosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりました、自分は問題ないと思います!
reviewに念の為、 @TakayukiCho も追加お願いします!

@nkmrh nkmrh requested a review from TakayukiCho October 31, 2024 07:43
@nkmrh nkmrh changed the title Implement clearCache and clearCacheAll Implement clearCache, clearCacheAll and getAllKeys Nov 25, 2024
Copy link

@harukitosa harukitosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
マージはテストのタイミングと合わせたいので少しお待ちください

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants