Fix potential bug where someone enters a negative page number into th…

…e paginator.
plainblack · Oct 24, 2024 · 5d9d218 · 5d9d218
1 parent 9595899
commit 5d9d218
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ving/docs/change-log.md b/ving/docs/change-log.md
@@ -12,6 +12,7 @@ outline: deep
  * Updated the redis client to trap bad connection strings with an error message.
  * Updated the drizzle client to use dotenv to get the connection string.
  * Updated the drizzle client to trap bad connection strings with an error message.
+ * Fix potential bug where someone enters a negative page number into the paginator.
 
 ### 2024-10-01
  * Added colin's patch for mysql pagination.

diff --git a/ving/record/VingRecord.mjs b/ving/record/VingRecord.mjs
@@ -871,7 +871,7 @@ export class VingKind {
             orderBy = cols;
         }
         const itemsPerPage = isUndefined(params?.itemsPerPage) || params?.itemsPerPage > 100 || params?.itemsPerPage < 1 ? 10 : params.itemsPerPage;
-        const page = params.page || 1;
+        const page = typeof params.page == 'undefined' || params.page < 1 ? 1 : params.page;
         const maxItems = params.maxItems || 100000000000;
         const itemsUpToThisPage = itemsPerPage * page;
         const fullPages = Math.floor(maxItems / itemsPerPage);