Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbusers - Groups and indexed data #1192

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix dbusers - Groups and indexed data #1192

wants to merge 2 commits into from

Conversation

rboixaderg
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Merging #1192 (602083a) into master (995e143) will increase coverage by 0.1%.
The diff coverage is 100.0%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1192     +/-   ##
========================================
+ Coverage    94.6%   94.6%   +0.1%     
========================================
  Files         377     378      +1     
  Lines       32771   32909    +138     
========================================
+ Hits        30992   31130    +138     
  Misses       1779    1779             
Files Coverage Δ
guillotina/contrib/dbusers/content/groups.py 97.6% <100.0%> (ø)
guillotina/contrib/dbusers/content/users.py 96.2% <100.0%> (ø)
guillotina/contrib/dbusers/services/groups.py 92.5% <ø> (ø)
guillotina/contrib/dbusers/services/users.py 88.8% <ø> (ø)
guillotina/contrib/dbusers/subscribers.py 94.0% <100.0%> (+0.5%) ⬆️
guillotina/contrib/dbusers/users.py 73.4% <ø> (ø)
guillotina/tests/dbusers/settings.py 100.0% <100.0%> (ø)
guillotina/tests/dbusers/test_manage_groups.py 100.0% <100.0%> (ø)
guillotina/tests/dbusers/test_search.py 100.0% <100.0%> (ø)

Copy link
Contributor

@masipcat masipcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think this PR should include a migration to reindex the JSON field

@rboixaderg
Copy link
Contributor Author

I need to review this part, because maybe we have an error in catalog when we use index_name property, also this affect in guillotina_elasticsearch.

@rboixaderg rboixaderg marked this pull request as draft January 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants