Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.meta distribution #241

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

gforcada
Copy link
Member

Closes #239

Finally, I had some time to breath and decided to bite the bullet: plone.meta is born 🎉

I'm by all means not a lawyer, and I can't remember what we decided regarding the license, I will check it up and update, but if anyone remembers, or has more knowledge about it, please share it 👍🏾

First step into turning this repository in a python installable package.
Shamelessly copied and adapted from zope.meta.
Otherwise when running the scripts, the templates were not found.
To make the scripts `--help` command work.
On zope.meta they replaced it with `update_python_support.py`.

We should do the same at some point.
To adjust them to be called as a command line tool.
@gforcada gforcada force-pushed the 239-turn-into-installable-package branch from 2859c44 to 1738b04 Compare December 23, 2024 10:37
@gforcada
Copy link
Member Author

@stevepiercy we have a huge config/README.md that with this change it has 2 problems:

  • it should probably be published somewhere, as it will be a proper python distribution
  • it will be partially outdated and adding a bit of structure might be nicer/easier for others to read

For the publishing part an easy short cut would be to, yet again, copy what zopefoundation/meta repository is doing: publishing the docs on readthedocs. I can copy/adapt their configuration and wish for the best 🤞🏾 otherwise advice on what to do would be great 🙇🏾

For the structure part I'm all open to suggestions and would be glad to get some advice. I will try my best to bend and twist the current documentation to the new proposed structure.

@stevepiercy
Copy link
Contributor

For a good best practice repo, check out https://github.com/plone/plone-sphinx-theme. I plan to use it for a Plone docs distribution.

I'll be offline for a couple days, but will check back later.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor grammar thing for the moment. Otherwise LGTM.

news/239.feature Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

@gforcada I put together a PR for Plone 6 Documentation. It's a how-to guide.

We've adopted the Diátaxis Framework for structuring docs, and we're slowly moving toward it, instead of having a mixture of all the quadrants in a page.

mauritsvanrees and others added 5 commits January 14, 2025 13:40
Co-authored-by: Steve Piercy <[email protected]>
This was still pointing to the zopefoundation org.
And errors were not shown, for example when running on a repo in the collective:

```
$ ./venv/bin/re-enable-actions
...
plone.app.locales
ABORTING: Please fix the errors shown above.
Proceed anyway (y/N)?
```
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

I have committed a few fixes, please check.

I think the only thing left is documentation. The config/README.md could be merged into the main README, making the config directory completely empty. It needs some updates because the installation is different. You don't call python config-package.py, but ./venv/bin/config-package.

Or we do that in plone/documentation#1830, and let the plone/meta/README.md point to the new guide.

src/plone/meta/default/packages.txt Outdated Show resolved Hide resolved
src/plone/meta/re_enable_actions.py Outdated Show resolved Hide resolved
src/plone/meta/re_enable_actions.py Outdated Show resolved Hide resolved
src/plone/meta/re_enable_actions.py Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

think the only thing left is documentation. The config/README.md could be merged into the main README, making the config directory completely empty.

I agree.

I also want to reorganize sections, putting how-to stuff first (install, usage, then configuration, as that's a common workflow), and move the explanation stuff last (philosophy).

It needs some updates because the installation is different. You don't call python config-package.py, but ./venv/bin/config-package.

It was renamed to config_package.py, so should that command change, too?

Or we do that in plone/documentation#1830, and let the plone/meta/README.md point to the new guide.

My original thought was to make Plone Documentation of plone/meta be minimalist and refer to the README. The current README confused this simple-minded first-timer, and writing that pull request was designed to reduce confusion from the next first-timer. That idea would also give plone/meta more exposure. However we could reverse that idea, and move all the docs from the README into Plone Documentation and link to that. I'm fine with either option.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar fix.

src/plone/meta/re_enable_actions.py Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

AFAICT, the only thing keeping this PR from being merged is a decision on the direction of docs. I'd like to work on the docs and wrap this up, but not without a decision for their direction. I don't want to spend time on things that aren't wanted.

The options are:

  1. Do nothing further and close Add Standardize Python project configuration developer guide documentation#1830.
  2. Merge contents of the readmes into the root.
  3. Move content of the readmes to Add Standardize Python project configuration developer guide documentation#1830, and have a single readme at the root that has a link to the docs.

@gforcada @mauritsvanrees @davisagli @ericof and anyone else who cares, what is your decision?

@mauritsvanrees
Copy link
Member

I would say number 2, merge contents of the readmes into the root. Main reason: if you add a new option to plone.meta, you can do that in one PR, instead of having to do a separate PR for the documentation.

A guide in the docs is still good. It makes people aware that there is such a thing as plone/meta. That could contain just basic installation and usage instructions. So roughly what the current docs PR does. And then point at the plone/meta repo for details.

BTW, once the current plone/meta PR is merged, I think we should add this repo to buildout.coredev in the sources, always have it checked out just like the docs, and add a buildout part like this so the commands are available:

[meta]
recipe = zc.recipe.egg
eggs =
    plone.meta

@gforcada Does all this make sense to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn plone/meta into a real installable Python package
3 participants