-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plone.meta distribution #241
base: main
Are you sure you want to change the base?
Conversation
First step into turning this repository in a python installable package.
Shamelessly copied and adapted from zope.meta.
Otherwise when running the scripts, the templates were not found.
To make the scripts `--help` command work.
On zope.meta they replaced it with `update_python_support.py`. We should do the same at some point.
To adjust them to be called as a command line tool.
2859c44
to
1738b04
Compare
@stevepiercy we have a huge
For the publishing part an easy short cut would be to, yet again, copy what For the structure part I'm all open to suggestions and would be glad to get some advice. I will try my best to bend and twist the current documentation to the new proposed structure. |
For a good best practice repo, check out https://github.com/plone/plone-sphinx-theme. I plan to use it for a Plone docs distribution. I'll be offline for a couple days, but will check back later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor grammar thing for the moment. Otherwise LGTM.
@gforcada I put together a PR for Plone 6 Documentation. It's a how-to guide. We've adopted the Diátaxis Framework for structuring docs, and we're slowly moving toward it, instead of having a mixture of all the quadrants in a page. |
Co-authored-by: Steve Piercy <[email protected]>
This was still pointing to the zopefoundation org. And errors were not shown, for example when running on a repo in the collective: ``` $ ./venv/bin/re-enable-actions ... plone.app.locales ABORTING: Please fix the errors shown above. Proceed anyway (y/N)? ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks!
I have committed a few fixes, please check.
I think the only thing left is documentation. The config/README.md
could be merged into the main README
, making the config
directory completely empty. It needs some updates because the installation is different. You don't call python config-package.py
, but ./venv/bin/config-package
.
Or we do that in plone/documentation#1830, and let the plone/meta/README.md
point to the new guide.
I agree. I also want to reorganize sections, putting how-to stuff first (install, usage, then configuration, as that's a common workflow), and move the explanation stuff last (philosophy).
It was renamed to
My original thought was to make Plone Documentation of |
Co-authored-by: Steve Piercy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar fix.
Co-authored-by: Steve Piercy <[email protected]>
AFAICT, the only thing keeping this PR from being merged is a decision on the direction of docs. I'd like to work on the docs and wrap this up, but not without a decision for their direction. I don't want to spend time on things that aren't wanted. The options are:
@gforcada @mauritsvanrees @davisagli @ericof and anyone else who cares, what is your decision? |
I would say number 2, merge contents of the readmes into the root. Main reason: if you add a new option to A guide in the docs is still good. It makes people aware that there is such a thing as plone/meta. That could contain just basic installation and usage instructions. So roughly what the current docs PR does. And then point at the plone/meta repo for details. BTW, once the current
@gforcada Does all this make sense to you? |
Closes #239
Finally, I had some time to breath and decided to bite the bullet: plone.meta is born 🎉
I'm by all means not a lawyer, and I can't remember what we decided regarding the license, I will check it up and update, but if anyone remembers, or has more knowledge about it, please share it 👍🏾