Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First refactor to use new setup and VLT #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

First refactor to use new setup and VLT #180

wants to merge 2 commits into from

Conversation

sneridagh
Copy link
Member

I had to remove all blocks that still relied on "draftJS" T_T which are a lot. Hoping that they are not used in plone.org and we don't have to write migrations.

@sneridagh sneridagh requested review from ericof and fredvd June 17, 2024 13:38
@ericof
Copy link
Member

ericof commented Jun 17, 2024

@sneridagh, @fredvd I would suggest first making sure we have a report on the used blocks. (I'm not sure if the blocks index is available on plone.org)

@sneridagh
Copy link
Member Author

@Fosten Hero is deprecated in Volto 18. It can be easily replaced by the Teaser. We will have to evaluate if it's worth the effort use an equivalent (slate based), or make the move to Teaser.

Same for others, depending on the usage... then evaluate if it's worth the effort or not.

@Fosten
Copy link
Contributor

Fosten commented Jun 21, 2024

All of the Hero blocks listed above have been removed. I didn't use Teaser blocks as they required a link, and none of these Hero blocks linked anywhere, but were just fancy ways to display image/text. Instead I replaced them with the "Text 7" Block as that seemed to be the closest match.

Screen Shot 2024-06-21 at 10 43 51 AM

Let me know if anything else needs cleaned up as per https://6.docs.plone.org/volto/upgrade-guide/index.html#draftjs-dependency-and-text-table-and-hero-blocks-removed

Generating a report on used blocks as @ericof suggested seems like a good idea.

@rioksane
Copy link
Collaborator

rioksane commented Nov 30, 2024

Reviewed the plone.org site with Victor. Some notes:

  • Try now can be added as an action in zope/classic OK
  • Megamenu works directly OK
  • Frontpage can be redone manually OK
  • Slider replaces main banner OK
  • Make a variation to teaser with a button
  • Replace text block 7 manually with gridblock: image + text - OK
  • Check another issue about footer changes: Add Plone newsletter sign up page link to Plone.org footer  #182
  • Numbers block nice to have but not mandatory
  • Replace tab block with grid blocks
  • Case study content type is in use
  • Flag color in the slider would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants