-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First refactor to use new setup and VLT #180
base: main
Are you sure you want to change the base?
Conversation
@sneridagh, @fredvd I would suggest first making sure we have a report on the used blocks. (I'm not sure if the blocks index is available on plone.org) |
@sneridagh Hero block is used in many places:
This list is a quick scan, but there may be a few more. @rioksane Let's get this on the agenda. Shouldn't take long to update. |
@Fosten Hero is deprecated in Volto 18. It can be easily replaced by the Teaser. We will have to evaluate if it's worth the effort use an equivalent (slate based), or make the move to Teaser. Same for others, depending on the usage... then evaluate if it's worth the effort or not. |
All of the Hero blocks listed above have been removed. I didn't use Teaser blocks as they required a link, and none of these Hero blocks linked anywhere, but were just fancy ways to display image/text. Instead I replaced them with the "Text 7" Block as that seemed to be the closest match. Let me know if anything else needs cleaned up as per https://6.docs.plone.org/volto/upgrade-guide/index.html#draftjs-dependency-and-text-table-and-hero-blocks-removed Generating a report on used blocks as @ericof suggested seems like a good idea. |
Reviewed the plone.org site with Victor. Some notes:
|
I had to remove all blocks that still relied on "draftJS" T_T which are a lot. Hoping that they are not used in plone.org and we don't have to write migrations.