-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http-fast-listen option for waitress #75
Conversation
@tschorr thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
1 similar comment
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I am not an expert exactly on WSGI and waitress, but it looks ok. Was it tested on Windows?
Hm, there are broken tests, I'd like to review after they are fixed. |
There are broken doctests after merging master. I'm about to fix them. Don't merge |
…deps, coevered so far by buildout version pins)
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I only read the code, I did not try it out.
I got confused a bit by some function names, maybe they could be changed for clarity.
@icemac I'm basically following https://pastedeploy.readthedocs.io/en/latest/#paste-server-factory. I opted for |
@jenkins-plone-org please run jobs |
Again the one failing robot test looks unrelated. |
Indeed, I merge this one now. |
s. #71 (and also zopefoundation/Zope#416).
waitress.serve() accepts a list of (prebound) sockets, https://waitress.readthedocs.io/en/latest/arguments.html.
Suggestion is to bind a socket before loading the application and to use a custom server_factory to make this work with PasteDeploy. This could also be done in https://github.com/zopefoundation/Zope, but plone.recipe.zope2instance is already relying on waitress anyway (Zope doesn't really seem to depend on waitress even though it is currently required it in it's setup.py).