Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth search issue #6558

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

TechSubham
Copy link
Member

Closes #5856

Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit d81a6cb
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6771c14555503100080d8dc9

@TechSubham
Copy link
Member Author

I have fixed the bug , i request someone to review the changes i have made

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started my review, and realized that I already reviewed most of this stuff from your earlier PR. See my suggestion about how to fix this branch. Until you do, no one else should look at this PR.

packages/volto/cypress/downloads/downloads.html Outdated Show resolved Hide resolved
packages/volto/src/icons/save1.svg Outdated Show resolved Hide resolved
packages/volto/src/icons/save2 2.crdownload Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/news/2039.feature Outdated Show resolved Hide resolved
@TechSubham
Copy link
Member Author

I have fixed the errors and i am sorry for the inconvenience caused

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the change log, I think this is ready for a review from the Volto Team. Thank you for your work!

packages/volto/news/5856.bugfix Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

@mbarde would you please check out this branch and test it to ensure it resolves the issue you reported, and let us know? Thank you!

Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy stevepiercy requested a review from a team December 29, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search block ignores depth setting
3 participants