-
-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depth search issue #6558
base: main
Are you sure you want to change the base?
Depth search issue #6558
Conversation
✅ Deploy Preview for plone-components canceled.
|
I have fixed the bug , i request someone to review the changes i have made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started my review, and realized that I already reviewed most of this stuff from your earlier PR. See my suggestion about how to fix this branch. Until you do, no one else should look at this PR.
13b9a56
to
6a8d111
Compare
6a8d111
to
045a4e8
Compare
I have fixed the errors and i am sorry for the inconvenience caused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating the change log, I think this is ready for a review from the Volto Team. Thank you for your work!
@mbarde would you please check out this branch and test it to ensure it resolves the issue you reported, and let us know? Thank you! |
Co-authored-by: Steve Piercy <[email protected]>
Closes #5856