Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing link can handle more than one @ #6598

Closed
wants to merge 3 commits into from

Conversation

Shyam-Raghuwanshi
Copy link

Closes #6448

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit eb88e97
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/678964565a545000080c72bc

@stevepiercy
Copy link
Collaborator

@Shyam-Raghuwanshi please see https://6.docs.plone.org/contributing/first-time.html#work-with-github-issues, especially Items 2 and 3 in that list. It will save you some time, effort, and frustration.

There is no consensus yet on the correct regex or process to use for validating mailto URLs. That has to happen first, so I'm closing this PR. Nonetheless, this snippet from your PR would be useful examples to discuss in the original issue.

@Shyam-Raghuwanshi Shyam-Raghuwanshi deleted the fix-links branch January 17, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links containing two @ signs can't be added
2 participants