Adds "aad group user list" command. Closes #5469

[nanddeepn]

Adds aad group user list command. Closes #5469

😍 Happy Hacktoberfest !

[Jwaegebaert]

Hey @nanddeepn, looks like the docs job is failing. Could you take a look at that?

[nanddeepn]

Hi @Jwaegebaert
Any guidance, how can I reproduce this locally?
May be this can help? https://pnp.github.io/cli-microsoft365/contribute/new-command/writing-the-docs/#running-docusaurus-locally

[Jwaegebaert]

Yes, indeed. By following the link you posted you should be able to reproduce it locally

[nanddeepn]

Hi @Jwaegebaert
I tried the instructions locally and the documentation seems to be working fine.

Anything else, I am missing here?

[nanddeepn]

docs job fails, when I add below to sidebars.js. Any suggestions please?

{
     type: 'doc',
     label: 'group user list',
     id: 'cmd/aad/group/group-user-list'
}

[Jwaegebaert]

@nanddeepn, we're looking into it. It seems to be more complex than we imagined. I'll keep you posted once we find something.

[martinlingstuyl]

Hi @nanddeepn, thanks for your contribution. I did a review and have some comments. I also have a point of open discussion I'm not yet sure about. I'll ping Milan about it.

[martinlingstuyl]

Hi @nanddeepn, I've discussed this internally, and it seems we've got an interesting confusion here. 'Owners and Members' are something else then 'Members and Guests', the userType property is an example of the last. MS graph returns user objects, and userType is simply a user property there.

It's the fault of the specs, so we'll be changing the specs. In its current state it's just not feasible and confusing.

We've seen that this code is a copy of m365group user list, so that command will need to change as well (later on)

You'll see it when the specs have been updated.

[martinlingstuyl]

He @nanddeepn, the specs have not yet been updated, 😂 you'll have to wait some more..

[milanholemans]

Hi @nanddeepn

We took a few days to look at the issue you are facing with Docusaurus.

In a nutshell:

We managed to get it working again by adding an extra config value: trailingSlash: false. This should be added in the Docusaurus config file here:

cli-microsoft365/docs/docusaurus.config.js

Lines 6 to 15 in 8b56e1d

	title: 'CLI for Microsoft 365',
	titleDelimiter: '-',
	tagline: 'Docs',
	url: 'https://pnp.github.io',
	baseUrl: '/cli-microsoft365/',
	onBrokenLinks: 'throw',
	onBrokenMarkdownLinks: 'throw',
	favicon: 'img/favicon.ico',
	organizationName: 'pnp',
	projectName: 'cli-microsoft365',

Why does this make the pipeline work? We have no idea, to be honest. In fact, we even reached out to the mods/maintainers of Docusaurus, and even they have no idea what caused this issue and why the trailingSlash is fixing it.
As far as we know, this setting can't hurt us, so we'll take it as a solution. Could you add it to this PR?

Thanks!

[martinlingstuyl]

Hi @nanddeepn, let's look at some comments before we merge this...

[martinlingstuyl]

Hi @nanddeepn, I've got a few last round comments. We'll merge this as soon as possible afterwards.

[martinlingstuyl]

Looks fine with some last cosmetic changes

[martinlingstuyl]

Let's use manager/displayName as example.

Let's include an extra example with manager/*

[martinlingstuyl]

Merged manually, thanks 👏