Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates existing md output in docs to exclude nested parameters. Closes #4793 #5544

Closed
wants to merge 3 commits into from

Conversation

SmitaNachan
Copy link
Contributor

Updates existing md output in docs to exclude nested parameters. Closes #4793

@milanholemans
Copy link
Contributor

Thank you @SmitaNachan, we'll try to review it ASAP!

@martinlingstuyl martinlingstuyl self-assigned this Oct 4, 2023
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @SmitaNachan, I have some minor comments. Let's fix those before we merge.

docs/docs/cmd/planner/task/task-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/planner/task/task-set.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/commandset/commandset-list.mdx Outdated Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft October 4, 2023 09:08
@SmitaNachan SmitaNachan marked this pull request as ready for review October 5, 2023 10:48
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Will merge it soon..

@martinlingstuyl
Copy link
Contributor

Merged manually, thanks for contributing, you rock! 😊🌶️

@martinlingstuyl martinlingstuyl added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 13, 2023
@SmitaNachan SmitaNachan deleted the issue-4793 branch December 13, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update existing md output in docs to exclude nested parameters
3 participants