Fixes: Allow saving SP page with an existing collapsible section. Closes #6462

[mkm17]

Closes #6462
Changes in page clientsidewebpart add and page text add commands to handle existing collapsible sections when saving an SP page.

In this PR, I have also updated the page text add test file to align with the latest recommendations.

Just one comment, I believe we also need to add some handlers for the controlType":0,"pageSettingsSlice... element, which is also visible in the page context.

[milanholemans]

Thanks @mkm17! We'll try to review it ASAP.

Just one comment, I believe we also need to add some handlers for the controlType":0,"pageSettingsSlice... element, which is also visible in the page context.

Could you clarify this a bit more, please?

[mkm17]

hi @milanholemans, I noticed that on a page, there is an additional element with controlType: 0 and some page settings. In the page text add command, during the changes to the command, this setting is omitted (during updates in clientsidepage.ts and Page.ts). In the page clientsidewebpart add command, as far as I remember, it is handled better, but the method used to add new parts to the page is implemented differently.

To be honest, I am not sure what we can do with it. I noticed that the clientsidepage.ts and Page.ts are also used in different commands. We could use a similar approach to page clientsidewebpart add and implement it in the page text add and other commands, or simply update page text add (and possibly other commands) to handle controlType:0.

[milanholemans]

To be honest, I have no idea why we have Page.ts and clientsidepage.ts. It feels like it should be one util file.
Do you have more info about this @pnp/cli-for-microsoft-365-maintainers?