Resolving comments from Adam wojcik

pnp · Oct 30, 2024 · 3ced9de · 3ced9de
1 parent afe07b8
commit 3ced9de
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 68 deletions.
diff --git a/samples/react-command-print/spfx-upgrade-report-v1.11.md b/samples/react-command-print/spfx-upgrade-report-v1.11.md
diff --git a/samples/react-command-print/spfx-upgrade-report-v1.13.0.md b/samples/react-command-print/spfx-upgrade-report-v1.13.0.md
diff --git a/samples/react-command-print/spfx-upgrade-report-v1.15.0.md b/samples/react-command-print/spfx-upgrade-report-v1.15.0.md
diff --git a/samples/react-command-print/spfx-upgrade-report-v1.16.1.md b/samples/react-command-print/spfx-upgrade-report-v1.16.1.md
diff --git a/samples/react-command-print/src/extensions/print/PrintCommandSet.ts b/samples/react-command-print/src/extensions/print/PrintCommandSet.ts
@@ -59,7 +59,7 @@ export default class PrintCommandSet extends BaseListViewCommandSet<IPrintComman
         dialog.itemId = event.selectedRows[0].getValueByName('ID');
         dialog.title = event.selectedRows[0].getValueByName('Title');
         dialog.show().then(()=>{
-          //Dialog.alert(''); //This line prevents issues with the dialog, please do not remove it/
+          Log.info(LOG_SOURCE, 'Dialog open');
         });
         break;
       default:

diff --git a/...mmand-print/src/extensions/print/components/print-dialog-content/print-dialog-content.tsx b/...mmand-print/src/extensions/print/components/print-dialog-content/print-dialog-content.tsx
@@ -10,7 +10,6 @@ import IPrintDialogContentProps from './print-dialog-content-props';
 import IPrintDialogContentState from './print-dialog-content-state';
 import PrintTemplateContent from '../print-dialog-template-content/print-template-content';
 import SettingsPanel from '../settings-panel/settings-panel';
-// import ListHelper from '../../util/list-helper';
 import ReactHtmlParser from 'react-html-parser';
 import {
     Dropdown

diff --git a/samples/react-command-print/src/extensions/print/util/list-helper.ts b/samples/react-command-print/src/extensions/print/util/list-helper.ts