Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two broken references in "react-company-templates" #1377

Closed
wants to merge 2 commits into from

Conversation

tmaestrini
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
New sample? no

What's in this Pull Request?

This PR fixes three incorrect references due to copy-paste errors in the solution template used by the author.
That said, it changes

  • the solution id to ensure sure it won't clash with any solution id that is used in another sample extension
  • the location of the action button of the command set and
  • the component reference of the action button to match the correct extension id used in the manifest

This update is necessary, otherwise the solution can cause side effects when using it in production.

@tmaestrini tmaestrini closed this Apr 6, 2024
@tmaestrini
Copy link
Contributor Author

I forgot to check in another fix – sorry! I will reopen a new PR. 🙏

@tmaestrini tmaestrini reopened this Apr 6, 2024
@tmaestrini tmaestrini closed this Apr 6, 2024
@tmaestrini
Copy link
Contributor Author

Opened another (correct) PR: #1378
Sorry for causing any troubles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant