fixup

pnp · Oct 24, 2024 · 7dde000 · 7dde000
1 parent bce9c45
commit 7dde000
Show file tree

Hide file tree

Showing 7 changed files with 440 additions and 18 deletions.
diff --git a/samples/react-pnp-js-sample/.devcontainer/devcontainer.json b/samples/react-pnp-js-sample/.devcontainer/devcontainer.json
@@ -1,7 +1,7 @@
 // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
 {
-	"name": "SPFx 1.15.2",
-	"image": "docker.io/m365pnp/spfx:1.15.2",
+	"name": "SPFx 1.20.0",
+	"image": "docker.io/m365pnp/spfx:1.20.0",
 	// Set *default* container specific settings.json values on container create.
 	"settings": {},
 	// Add the IDs of extensions you want installed when the container is created.

diff --git a/samples/react-pnp-js-sample/.yo-rc.json b/samples/react-pnp-js-sample/.yo-rc.json
@@ -3,12 +3,17 @@
     "plusBeta": true,
     "isCreatingSolution": true,
     "environment": "spo",
-    "version": "1.15.2",
+    "version": "1.20.0",
+    "nodeVersion": "18.20.3",
     "libraryName": "spfx-pnp-js-example",
     "libraryId": "d20ceaf6-094b-4086-b7a0-85761bc8be23",
     "packageManager": "npm",
     "solutionShortDescription": "spfx-pnp-js-example description",
     "isDomainIsolated": false,
-    "componentType": "webpart"
+    "componentType": "webpart",
+    "sdkVersions": {
+      "@microsoft/teams-js": "2.24.0",
+      "@microsoft/microsoft-graph-client": "3.0.2"
+    }
   }
 }
diff --git a/samples/react-pnp-js-sample/config/sass.json b/samples/react-pnp-js-sample/config/sass.json
@@ -0,0 +1,3 @@
+{
+    "$schema": "https://developer.microsoft.com/json-schemas/core-build/sass.schema.json"
+}
diff --git a/samples/react-pnp-js-sample/config/serve.json b/samples/react-pnp-js-sample/config/serve.json
@@ -2,5 +2,5 @@
   "$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
   "port": 4321,
   "https": true,
-  "initialPage": "https://enter-your-SharePoint-site/_layouts/workbench.aspx"
+  "initialPage": "https://{tenantDomain}/_layouts/workbench.aspx"
 }
diff --git a/samples/react-pnp-js-sample/package.json b/samples/react-pnp-js-sample/package.json
@@ -14,12 +14,12 @@
     "dependencies": {
         "@fluentui/react": "8.106.4",
         "@microsoft/generator-sharepoint": "1.20.0",
-        "@microsoft/sp-adaptive-card-extension-base": "^1.20.0",
-        "@microsoft/sp-core-library": "^1.20.0",
-        "@microsoft/sp-lodash-subset": "^1.20.0",
-        "@microsoft/sp-office-ui-fabric-core": "^1.20.0",
-        "@microsoft/sp-property-pane": "^1.20.0",
-        "@microsoft/sp-webpart-base": "^1.20.0",
+        "@microsoft/sp-adaptive-card-extension-base": "1.20.0",
+        "@microsoft/sp-core-library": "1.20.0",
+        "@microsoft/sp-lodash-subset": "1.20.0",
+        "@microsoft/sp-office-ui-fabric-core": "1.20.0",
+        "@microsoft/sp-property-pane": "1.20.0",
+        "@microsoft/sp-webpart-base": "1.20.0",
         "@pnp/graph": "^4.0.1",
         "@pnp/logging": "^4.0.1",
         "@pnp/sp": "^4.0.1",
@@ -28,17 +28,17 @@
         "tslib": "2.3.1"
     },
     "devDependencies": {
-        "@microsoft/eslint-config-spfx": "1.20.1",
-        "@microsoft/eslint-plugin-spfx": "1.20.1",
-        "@microsoft/rush-stack-compiler-4.7": "^0.1.0",
-        "@microsoft/sp-build-web": "1.20.1",
-        "@microsoft/sp-module-interfaces": "1.20.1",
-        "@rushstack/eslint-config": "2.5.1",
+        "@microsoft/eslint-config-spfx": "1.20.2",
+        "@microsoft/eslint-plugin-spfx": "1.20.2",
+        "@microsoft/rush-stack-compiler-4.7": "0.1.0",
+        "@microsoft/sp-build-web": "1.20.2",
+        "@microsoft/sp-module-interfaces": "1.20.2",
+        "@rushstack/eslint-config": "4.0.1",
         "@types/react": "17.0.45",
         "@types/react-dom": "17.0.17",
         "@types/webpack-env": "1.18.2",
         "ajv": "6.12.5",
-        "eslint": "8.7.0",
+        "eslint": "8.57.0",
         "eslint-plugin-react-hooks": "4.3.0",
         "gulp": "~4.0.2",
         "typescript": "4.7.4"