Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React personal tools list – enhanced web part properties for list handling #4746

Merged

Conversation

tmaestrini
Copy link

@tmaestrini tmaestrini commented Feb 25, 2024

What's in this Pull Request?

This PR enhances the existing version of the sample by providing three additional web part properties: a target site and the two necessary lists can be selected via site picker and list picker components. The components and hooks were adjusted accordingly. The README file contains an according description.

Node Version

Node version used: 1.18.0

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@tmaestrini tmaestrini changed the title React personal tools list multi site handling React personal tools list – enhanced web part properties for list handling Feb 25, 2024
@tmaestrini
Copy link
Author

tmaestrini commented Mar 5, 2024

Hello @hugoabernier, sorry for bothering you with my question:
Do you know if there is any news on the progress of this PR?
Thanks for a short feedback...

@hugoabernier
Copy link
Collaborator

@tmaestrini thanks for inquiring. We typically process pull requests once every 2 weeks, except when we're on vacation. I'll be processing the pull request this week/weekend.

@tmaestrini
Copy link
Author

@hugoabernier thank you very much for your reply! GlaD to hear.

@hugoabernier hugoabernier merged commit 7536d89 into pnp:main Mar 10, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Thank you @tmaestrini ! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants