-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded to spfx-v1.20.0 #5271
upgraded to spfx-v1.20.0 #5271
Conversation
Thank you for opening a PR to our samples repo and helping us upgrade our project 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NishkalankBezawada awesome work so far 👏👏👏👏
I had a quick check end left some comments I think we should resolve before merging. Please do give them a double check before we proceed 🙏
Also I was unable to successfully build the project 🤔
Also:
Please also update the sample.json file in assets folder
This file holds the metadata of the sample which is present in the MS sample gallery. We should update the updateDateTime
filed and
{
"key": "SPFX-VERSION",
"value": "1.17.4"
}
as well to "value": "1.20.0"
Hey @Adam-it I have resolved the changes requested, now the project is building too. Thanks, |
Awesome 😍 |
@NishkalankBezawada are you sure you committed all the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rechecked locally but I am still unable to build it. Please check my previous comment
I am also unable to build. It does seem that the solution was built with a dev dependency on fast serve, but even after adding it, I wasn't able to serve the web part. |
Hello @hugoabernier & @Adam-it, Sorry for the delay, and inconvenience. I have verified and done neccesary changes, now the webpart is building and serving as well :) Thanks, |
Thanks @Nishkalank Bezawada for your update! Highly appreciated!. Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
What's in this Pull Request?
Upgraded the SharePoint Framework to v1.20.0
Node Version
SPFx Version
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.jsThanks,
Nishkalank Bezawada