-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React graph app secret expiration upgrade to SPFx v1.20 #5357
React graph app secret expiration upgrade to SPFx v1.20 #5357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a1mery Awesome work 👏. You Rock 🤩
I added a few comments regarding dependencies we should fixup before we merge.
We should also update the assets/sample.json
. This is metadata file that is used to present sample in the gallery. There you will find SPFX-VERSION
which should be updated to 1.20.0
@Adam-it thanks a lot for the review!! |
@Adam-it I was able to make suggested changes! |
Thank you for your awesome work and ASAP response 👍. You are awesome 🤩 |
Thank you @a1mery for your update! Awesome!. Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
What's in this Pull Request?
Upgrade sample to SPFx version 1.20
Node Version
Node version used: v18.18.0
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.js