Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React graph app secret expiration upgrade to SPFx v1.20 #5357

Merged

Conversation

a1mery
Copy link
Contributor

@a1mery a1mery commented Dec 9, 2024

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Upgrade sample to SPFx version 1.20

Node Version

Node version used: v18.18.0

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a1mery Awesome work 👏. You Rock 🤩

I added a few comments regarding dependencies we should fixup before we merge.
We should also update the assets/sample.json. This is metadata file that is used to present sample in the gallery. There you will find SPFX-VERSION which should be updated to 1.20.0

@Adam-it Adam-it marked this pull request as draft January 8, 2025 23:57
@a1mery
Copy link
Contributor Author

a1mery commented Jan 9, 2025

@Adam-it thanks a lot for the review!! ☺️ I will take care of it 💪

@a1mery
Copy link
Contributor Author

a1mery commented Jan 10, 2025

@Adam-it I was able to make suggested changes!
Upgrading eslint packages was a bit more complex than expected but I made it 😊

@a1mery a1mery marked this pull request as ready for review January 10, 2025 14:12
@a1mery a1mery requested a review from Adam-it January 10, 2025 14:14
@Adam-it
Copy link
Member

Adam-it commented Jan 12, 2025

@Adam-it I was able to make suggested changes! Upgrading eslint packages was a bit more complex than expected but I made it 😊

Thank you for your awesome work and ASAP response 👍. You are awesome 🤩
I will do my very best to find time for this PR in the upcoming week.

@hugoabernier hugoabernier merged commit ec58f9c into pnp:main Jan 13, 2025
3 checks passed
@hugoabernier
Copy link
Collaborator

Thank you @a1mery for your update! Awesome!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@a1mery a1mery deleted the react-graph-app-secret-expiration-upgrade-to-1.20 branch January 13, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants