Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sp service to pull current year birthdays #5374

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Update sp service to pull current year birthdays #5374

merged 6 commits into from
Jan 15, 2025

Conversation

gretchunkim
Copy link
Contributor

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ), make notes next to any that haven't been addressed.

What's in this Pull Request?

The Microsoft Graph API did not support the date function in the $filter parameter. This is why the graph api query was changed to get all listings then locally filter out upcoming birthdays.

Node Version

v20.18.1

Checklist

This checklist is used to automatically pre-process your pull request; It is meant to help process pull requests in a timely manner, rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ). Make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@github-actions GitHub Actions
Copy link

Validation failed!

File: samples/react-birthdays/assets/sample.json

@hugoabernier hugoabernier merged commit 8f90d4f into pnp:main Jan 15, 2025
2 of 3 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @gretchunkim for your update! Awesome!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gretchunkim @hugoabernier