Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-modern-birthdays upgrade to SPFx 1.20 #5378

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions samples/react-modern-birthdays/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,42 +22,6 @@ module.exports = {
'@typescript-eslint/adjacent-overload-signatures': 1,
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
//
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
'@typescript-eslint/ban-types': [
1,
{
'extendDefaults': false,
'types': {
'String': {
'message': 'Use \'string\' instead',
'fixWith': 'string'
},
'Boolean': {
'message': 'Use \'boolean\' instead',
'fixWith': 'boolean'
},
'Number': {
'message': 'Use \'number\' instead',
'fixWith': 'number'
},
'Object': {
'message': 'Use \'object\' instead, or else define a proper TypeScript type:'
},
'Symbol': {
'message': 'Use \'symbol\' instead',
'fixWith': 'symbol'
},
'Function': {
'message': 'The \'Function\' type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with \'new\'.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.'
}
}
}
],
// RATIONALE: Code is more readable when the type of every variable is immediately obvious.
// Even if the compiler may be able to infer a type, this inference will be unavailable
// to a person who is reviewing a GitHub diff. This rule makes writing code harder,
// but writing code is a much less important activity than reading it.
//
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
'@typescript-eslint/explicit-function-return-type': [
1,
Expand Down
1 change: 1 addition & 0 deletions samples/react-modern-birthdays/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v18.18.0
4 changes: 2 additions & 2 deletions samples/react-modern-birthdays/.yo-rc.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
"nodeVersion": "16.18.1",
"sdksVersions": {
"@microsoft/microsoft-graph-client": "3.0.2",
"@microsoft/teams-js": "2.4.1"
"@microsoft/teams-js": "2.24.0"
},
"version": "1.16.1",
"version": "1.20.0",
"libraryName": "react-birthdays",
"libraryId": "caf83914-77f3-470c-b71c-21d8820c48a9",
"environment": "spo",
Expand Down
6 changes: 4 additions & 2 deletions samples/react-modern-birthdays/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ The Web Part(s) shows the upcoming birthdays in the company, the web parts reads
| Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
|Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility. |

![SPFx 1.16.1](https://img.shields.io/badge/SPFx-1.16.1-green.svg)
![Node.js v16 | v14](https://img.shields.io/badge/Node.js-v16%20|%20v14-green.svg)
![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
![Node.js v18](https://img.shields.io/badge/Node.js-v18-green.svg)
![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg)
![Workbench Hosted: Does not work with local workbench](https://img.shields.io/badge/Workbench-Hosted-yellow.svg "Does not work with local workbench")
![Compatible with Remote Containers](https://img.shields.io/badge/Remote%20Containers-Compatible-green.svg)
Expand All @@ -42,12 +42,14 @@ email | Text | true
## Contributors

* [João Mendes](https://github.com/joaojmendes)
* [Aimery Thomas](https://github.com/a1mery)

## Version history

Version|Date|Comments
-------|----|--------
1.0.0|January 31, 2023|Initial release
1.1.0|January 19, 2025|Upgrade to SPFx v1.20.0

## Minimal Path to Awesome

Expand Down
18 changes: 14 additions & 4 deletions samples/react-modern-birthdays/assets/sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"Shows upcoming birthdays in the company, laid out in a timeline"
],
"creationDateTime": "2023-01-31",
"updateDateTime": "2023-01-31",
"updateDateTime": "2025-01-19",
"products": [
"SharePoint"
],
Expand All @@ -21,7 +21,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.16.1"
"value": "1.20.0"
}
],
"thumbnails": [
Expand All @@ -37,6 +37,11 @@
"gitHubAccount": "joaojmendes",
"pictureUrl": "https://github.com/joaojmendes.png",
"name": "João Mendes"
},
{
"gitHubAccount": "a1mery",
"pictureUrl": "https://github.com/a1mery.png",
"name": "Aimery Thomas"
}
],
"references": [
Expand All @@ -58,7 +63,7 @@
"The Web Part shows the upcoming birthdays in the company, the web parts reads birthdays from a list located on the tenant's root site with title \"Birthdays.\""
],
"creationDateTime": "2023-01-31",
"updateDateTime": "2023-01-31",
"updateDateTime": "2025-01-19",
"products": [
"SharePoint"
],
Expand All @@ -69,7 +74,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.16.1"
"value": "1.20.0"
}
],
"thumbnails": [
Expand All @@ -85,6 +90,11 @@
"gitHubAccount": "joaojmendes",
"pictureUrl": "https://github.com/joaojmendes.png",
"name": "João Mendes"
},
{
"gitHubAccount": "a1mery",
"pictureUrl": "https://github.com/a1mery.png",
"name": "Aimery Thomas"
}
],
"references": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"solution": {
"name": "react-birthdays-client-side-solution",
"id": "caf83914-77f3-470c-b71c-21d8820c48a9",
"version": "1.0.0.0",
"version": "1.1.0.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": true,
"isDomainIsolated": false,
Expand Down
2 changes: 1 addition & 1 deletion samples/react-modern-birthdays/config/serve.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
"port": 4321,
"https": true,
"initialPage": "https://enter-your-SharePoint-site/_layouts/workbench.aspx"
"initialPage": "https://{tenantDomain}/_layouts/workbench.aspx"
}
Loading
Loading