events: add missing return type #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing return type causes it to be defaulted to `int`, which subsequently results in a compilation error if `-Werror=return-type` or similar is set. Fixes: 9da7bdb ("events: add placeholder function instead of #if")
|
I have edited the commit message, please check it, and confirm that it is acceptable for you; then I can merge it. |
|
Yes, you definitely have my go-ahead. I still need to remind myself to be mindful of git commit messages. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my update to the nixpkgs package I found this blocking the build.
I have tested this patch as part of the packaging process, and it builds in Nix. I, however, didn't test this conditional compilation branch. I don't imagine it's necessary.