Skip to content

Commit

Permalink
[CLI] Filter Suppliers by ServiceID (#1028)
Browse files Browse the repository at this point in the history
## Summary

Update the supplier query endpoint to use **AutoCLI** and add a flag to
filter by `ServiceID`

### Primary Changes:
- Add `service_id` filter to `list-suppliers` query to support filtering
suppliers by service ID
- Update CLI command from `list-supplier` to `list-suppliers` for
improved clarity
- Change revenue share percentage field type from `float32` to `uint32`
to fix autoCLI issues

### Secondary changes:
- Update documentation and config examples to reflect the new revenue
share percentage type
- Remove legacy CLI commands in favor of autocli implementation

<img width="1286" alt="Screenshot 2025-01-16 at 12 58 06 PM"
src="https://github.com/user-attachments/assets/63583424-9a96-4195-82b0-6e58cc676e8b"
/>
<img width="1295" alt="Screenshot 2025-01-16 at 12 57 52 PM"
src="https://github.com/user-attachments/assets/f2c10d81-5e5d-4b76-b375-bd2190eba7a5"
/>



## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [x] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [x] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [x] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [ ] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [x] I create and reference any new tickets, if applicable
- [x] I have left TODOs throughout the codebase, if applicable
  • Loading branch information
Olshansk authored Jan 20, 2025
1 parent 0c52ba7 commit bb631a2
Show file tree
Hide file tree
Showing 57 changed files with 1,039 additions and 664 deletions.
2 changes: 1 addition & 1 deletion .github/workflows-helpers/run-e2e-test-job-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
ls -l /root/.poktroll/keyring-test/ && \
poktrolld q gateway list-gateway --node=$POCKET_NODE && \
poktrolld q application list-application --node=$POCKET_NODE && \
poktrolld q supplier list-supplier --node=$POCKET_NODE && \
poktrolld q supplier list-suppliers --node=$POCKET_NODE && \
make acc_initialize_pubkeys && \
go test -v ./e2e/tests/... -tags=e2e
env:
Expand Down
34 changes: 18 additions & 16 deletions api/poktroll/application/types.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

123 changes: 64 additions & 59 deletions api/poktroll/shared/service.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit bb631a2

Please sign in to comment.