Merge branch 'main' into validator-cheatsheet

pokt-network · Jan 29, 2025 · d0cfa03 · d0cfa03
2 parents 3e6e000 + 3345bd2
commit d0cfa03
Show file tree

Hide file tree

Showing 235 changed files with 2,955 additions and 1,667 deletions.
diff --git a/.env.dev b/.env.dev
@@ -16,7 +16,7 @@ GROVE_PORTAL_STAGING_ETH_MAINNET=https://eth-mainnet.rpc.grove.town
 # The "protocol" field here instructs the Grove gateway which network to use
 JSON_RPC_DATA_ETH_BLOCK_HEIGHT='{"protocol": "shannon-testnet","jsonrpc":"2.0","id":"0","method":"eth_blockNumber", "params": []}'
 
-# On-chain module account addresses. Search for `func TestModuleAddress` in the
+# Onchain module account addresses. Search for `func TestModuleAddress` in the
 # codebase to get an understanding of how we got these values.
 APPLICATION_MODULE_ADDRESS=pokt1rl3gjgzexmplmds3tq3r3yk84zlwdl6djzgsvm
 SUPPLIER_MODULE_ADDRESS=pokt1j40dzzmn6cn9kxku7a5tjnud6hv37vesr5ccaa

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,26 +1,15 @@
-<!-- READ & DELETE:
-    1. Add a descriptive title `[<Tag>] <DESCRIPTION>`
-    2. Update _Assignee(s)_
-    3. Add _Label(s)_
-    4. Set _Project(s)_
-    5. Specify _Epic_ and _Iteration_ under _Project_
-    6. Set _Milestone_
--->
-
 ## Summary
 
-<!-- READ & DELETE:
-    - Providing a quick summary of the changes yourself
--->
+< One line summary>
 
-## Issue
+Changes:
+- < Change 1 >
+- < Change 2 > 
 
-<!-- READ & DELETE:
-     - Explain the reasoning for the PR in 1-2 sentences. Adding a screenshot is fair game.
-     - If applicable: specify the ticket number below if there is a relevant issue; _keep the `-` so the full issue is referenced._
--->
+## Issue
 
-- #{ISSUE_NUMBER}
+- Description: < Description > 
+- Issue: #{ISSUE_NUMBER}
 
 ## Type of change
 
@@ -33,28 +22,11 @@ Select one or more from the following:
 - [ ] Documentation
 - [ ] Other (specify)
 
-## Testing
-
-<!-- READ & DELETE:
-- Documentation changes: only keep this if you're making documentation changes
-- Unit Testing: Remove this if you didn't make code changes
-- E2E Testing: Remove this if you didn't make code changes
-    - See the quickstart guide for instructions: https://dev.poktroll.com/developer_guide/quickstart
-- DevNet E2E Testing: Remove this if you didn't make code changes
-    - THIS IS VERY EXPENSIVE: only do it after all the reviews are complete.
-    - Optionally run `make trigger_ci` if you want to re-trigger tests without any code changes
-    - If tests fail, try re-running failed tests only using the GitHub UI as shown [here](https://github.com/pokt-network/poktroll/assets/1892194/607984e9-0615-4569-9452-4c730190c1d2)
--->
-
-- [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes
-- [ ] **Unit Tests**: `make go_develop_and_test`
-- [ ] **LocalNet E2E Tests**: `make test_e2e`
-- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.
-
 ## Sanity Checklist
 
-- [ ] I have tested my changes using the available tooling
-- [ ] I have commented my code
-- [ ] I have performed a self-review of my own code; both comments & source code
-- [ ] I create and reference any new tickets, if applicable
-- [ ] I have left TODOs throughout the codebase, if applicable
+- [ ] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone`
+- [ ] For docs, I have run `make docusaurus_start`
+- [ ] For code, I have run `make go_develop_and_test` and `make test_e2e`
+- [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI
+- [ ] For configurations, I have update the documentation
+- [ ] I added TODOs where applicable
diff --git a/.github/workflows-helpers/run-e2e-test-job-template.yaml b/.github/workflows-helpers/run-e2e-test-job-template.yaml
@@ -37,7 +37,7 @@ spec:
               ls -l /root/.poktroll/keyring-test/ && \
               poktrolld q gateway list-gateway --node=$POCKET_NODE && \
               poktrolld q application list-application --node=$POCKET_NODE && \
-              poktrolld q supplier list-supplier --node=$POCKET_NODE && \
+              poktrolld q supplier list-suppliers --node=$POCKET_NODE && \
               make acc_initialize_pubkeys && \
               go test -v ./e2e/tests/... -tags=e2e
           env:
@@ -50,13 +50,13 @@ spec:
             - name: POKTROLLD_HOME
               value: /root/.poktroll
             - name: PATH_URL
-              value: http://${NAMESPACE}-path:3000/v1
+              value: http://${NAMESPACE}-path:3069/v1
               # PATH relies on subdomains to get the requested service but our DevNet infra is not
               # built to expose arbitrary subdomains and supporting it would be a significant effort.
               # As a workaround, PATH_HOST_OVERRIDE is used as the host:port to connect to PATH while
               # the subdomain is passed as a Host header in the request.
             - name: PATH_HOST_OVERRIDE
-              value: ${NAMESPACE}-path:3000
+              value: ${NAMESPACE}-path:3069
           volumeMounts:
             - mountPath: /root/.poktroll/keyring-test/
               name: writable-keys-volume

diff --git a/.github/workflows/main-build.yml b/.github/workflows/main-build.yml
@@ -13,7 +13,7 @@ jobs:
   build-push-container:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: "0" # Per https://github.com/ignite/cli/issues/1674#issuecomment-1144619147
 

diff --git a/.github/workflows/release-artifacts.yml b/.github/workflows/release-artifacts.yml
@@ -13,7 +13,7 @@ jobs:
   release-artifacts:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: "0" # Per https://github.com/ignite/cli/issues/1674#issuecomment-1144619147
 
@@ -62,7 +62,7 @@ jobs:
             type=sha,format=long,suffix=-prod
 
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
@@ -82,7 +82,7 @@ jobs:
 
       # TODO_TECHDEBT(@okdas): use for releases (also change the "on" part at the top so it only tgirrered for tags/releases)
       - name: Add release and publish binaries
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
         with:
           files: |
             release/*
diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
@@ -67,7 +67,7 @@ jobs:
   # Ensure that we are using polylog (via logger.) instead of the golang's stdlib
   # log package.
   check_stdlog_in_off_chain_package:
-    name: Check stdlog in off-chain source code
+    name: Check stdlog in offchain source code
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -17,7 +17,7 @@ jobs:
   go-test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: "0" # Per https://github.com/ignite/cli/issues/1674#issuecomment-1144619147
 

diff --git a/.github/workflows/upload-pages-artifact.yml b/.github/workflows/upload-pages-artifact.yml
@@ -16,7 +16,7 @@ jobs:
   update-docs:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: "0" # Per https://github.com/ignite/cli/issues/1674#issuecomment-1144619147
 
@@ -32,7 +32,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Node.js
         uses: actions/setup-node@v4
@@ -63,7 +63,7 @@ jobs:
       pages: write
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Node.js
         uses: actions/setup-node@v4
@@ -83,15 +83,15 @@ jobs:
           yarn build
 
       - name: Setup Pages
-        uses: actions/configure-pages@v4
+        uses: actions/configure-pages@v5
         with:
           enablement: true
 
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v2
+        uses: actions/upload-pages-artifact@v3
         with:
           path: docusaurus/build
 
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v2
+        uses: actions/deploy-pages@v4
diff --git a/Dockerfile.release b/Dockerfile.release
@@ -8,7 +8,6 @@ RUN apt-get update && \
     apt-get install -y --no-install-recommends ca-certificates && \
     rm -rf /var/lib/apt/lists/*
 
-
 # Use `1025` G/UID so users can switch between this and `heighliner` image without a need to chown the files.
 RUN groupadd -g 1025 pocket && useradd -u 1025 -g pocket -m -s /sbin/nologin pocket
 

diff --git a/Makefile b/Makefile
@@ -14,7 +14,7 @@ GROVE_PORTAL_STAGING_ETH_MAINNET = https://eth-mainnet.rpc.grove.town
 # JSON RPC data for a test relay request
 JSON_RPC_DATA_ETH_BLOCK_HEIGHT = '{"jsonrpc":"2.0","id":"0","method":"eth_blockNumber", "params": []}'
 
-# On-chain module account addresses. Search for `func TestModuleAddress` in the
+# Onchain module account addresses. Search for `func TestModuleAddress` in the
 # codebase to get an understanding of how we got these values.
 APPLICATION_MODULE_ADDRESS = pokt1rl3gjgzexmplmds3tq3r3yk84zlwdl6djzgsvm
 SUPPLIER_MODULE_ADDRESS = pokt1j40dzzmn6cn9kxku7a5tjnud6hv37vesr5ccaa

diff --git a/Tiltfile b/Tiltfile
@@ -320,6 +320,9 @@ for x in range(localnet_config["path_gateways"]["count"]):
         "--set=metrics.serviceMonitor.enabled=" + str(localnet_config["observability"]["enabled"]),
         "--set=path.mountConfigMaps[0].name=path-config-" + str(actor_number),
         "--set=path.mountConfigMaps[0].mountPath=/app/config/",
+        "--set=fullnameOverride=path" + str(actor_number),
+        "--set=nameOverride=path" + str(actor_number),
+        "--set=global.serviceAccount.name=path" + str(actor_number),
     ]
 
     if localnet_config["path_local_repo"]["enabled"]:
@@ -360,7 +363,9 @@ for x in range(localnet_config["path_gateways"]["count"]):
         # ],
         # TODO_IMPROVE(@okdas): Add port forwards to grafana, pprof, like the other resources
         port_forwards=[
-                str(2999 + actor_number) + ":3000"
+                # See PATH for the default port used by the gateway. As of PR #1026, it is :3069.
+                # https://github.com/buildwithgrove/path/blob/main/config/router.go
+                str(2999 + actor_number) + ":3069"
         ],
     )
 

diff --git a/api/poktroll/application/types.pulsar.go b/api/poktroll/application/types.pulsar.go
diff --git a/api/poktroll/proof/params.pulsar.go b/api/poktroll/proof/params.pulsar.go
diff --git a/api/poktroll/proof/types.pulsar.go b/api/poktroll/proof/types.pulsar.go
diff --git a/api/poktroll/service/params.pulsar.go b/api/poktroll/service/params.pulsar.go
diff --git a/api/poktroll/service/relay.pulsar.go b/api/poktroll/service/relay.pulsar.go
diff --git a/api/poktroll/service/relay_mining_difficulty.pulsar.go b/api/poktroll/service/relay_mining_difficulty.pulsar.go
diff --git a/api/poktroll/session/types.pulsar.go b/api/poktroll/session/types.pulsar.go