[RelayMiner] Allow big transactions simulation #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olshansk
approved these changes
Jan 13, 2025
|
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
|
Pushed an empty commit to build an image |
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 1027) |
Olshansk
pushed a commit
that referenced
this pull request
Jan 16, 2025
## Summary
This pull request includes changes to support larger proof transactions
by increasing the maximum allowed sizes for RPC and mempool, and by
adjusting the gRPC client configuration.
## Issue
`RelayMiner`s simulate and broadcast transaction with multiple proofs
that tend to be too large than the default gRPC client's
`MaxCall{Send,Recv}MsgSize`.
## Type of change
Select one or more from the following:
- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [x] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)
## Testing
- [x] **Unit Tests**: `make go_develop_and_test`
- [x] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.
## Sanity Checklist
- [x] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [x] I have left TODOs throughout the codebase, if applicable
---------
Co-authored-by: Dmitry K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes changes to support larger proof transactions by increasing the maximum allowed sizes for RPC and mempool, and by adjusting the gRPC client configuration.
Issue
RelayMiners simulate and broadcast transaction with multiple proofs that tend to be too large than the default gRPC client'sMaxCall{Send,Recv}MsgSize.Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist