-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Migration] scaffold: module migration #1032
base: main
Are you sure you want to change the base?
Conversation
4338db9
to
6d9c3d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but PTAL at the one small comment
|
||
// InitGenesis initializes the module's state from a provided genesis state. | ||
func InitGenesis(ctx sdk.Context, k keeper.Keeper, genState types.GenesisState) { | ||
// this line is used by starport scaffolding # genesis/module/init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the ask is here, could you please elaborate?
@@ -0,0 +1,35 @@ | |||
package migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use autocli this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 - autoCLI only applies to the claim step though, so you'll see skip: true
until #1046.
The state upload step requires authorization, which I would do the same way that we do param updates: authz dao genesis authorization + a make target + authz message JSON.
I don't think the export/import transform can't be done via autocli because it's not a gRPC service/message.
Summary
ignite scaffold module migration
NOTE: The
--dep
flag consistently failed to work for me, resulting in the following error (for any dep module); e.g.:Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist