Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Morse->Shannon Migration] Scaffold MsgUploadMorseState #1035

Closed
wants to merge 6 commits into from
Closed

[Morse->Shannon Migration] Scaffold MsgUploadMorseState #1035

wants to merge 6 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Jan 20, 2025 •
edited
Loading

SUPERSEDED BY #1045

Summary

ignite scaffold message upload-morse-state --module migration --signer authority state

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Jan 20, 2025
@bryanchriswhite bryanchriswhite self-assigned this Jan 20, 2025
@bryanchriswhite bryanchriswhite linked an issue Jan 20, 2025 that may be closed by this pull request
[Morse->Shannon Migration] Migration module #1034
Open
9 tasks
@bryanchriswhite bryanchriswhite force-pushed the scaffold/migration/morse-state branch 2 times, most recently from da08fdb to 73bb345 Compare January 21, 2025 12:55
@bryanchriswhite bryanchriswhite mentioned this pull request Jan 22, 2025
Open
9 tasks
@bryanchriswhite bryanchriswhite force-pushed the scaffold/migration/morse-state branch from edad645 to d9d6cb3 Compare January 27, 2025 16:17
@bryanchriswhite bryanchriswhite changed the base branch from scaffold/migration-module to chore/migration/state-prep January 27, 2025 16:21
@bryanchriswhite bryanchriswhite force-pushed the scaffold/migration/morse-state branch from d9d6cb3 to 3e715e5 Compare January 27, 2025 16:26
@bryanchriswhite bryanchriswhite marked this pull request as ready for review January 27, 2025 16:52
bryanchriswhite
bryanchriswhite commented Jan 29, 2025
View reviewed changes
proto/poktroll/migration/tx.proto

message MsgUploadMorseStateResponse {
string state_hash = 1 [(gogoproto.jsontag) = "state_hash"];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string state_hash = 1 [(gogoproto.jsontag) = "state_hash"];
bytes state_hash = 1 [(gogoproto.jsontag) = "state_hash"];

@bryanchriswhite bryanchriswhite mentioned this pull request Jan 29, 2025
Open
12 tasks
@bryanchriswhite bryanchriswhite marked this pull request as draft January 29, 2025 12:42
@bryanchriswhite
Copy link
Contributor Author

SUPERSEDED BY #1045

@bryanchriswhite bryanchriswhite deleted the scaffold/migration/morse-state branch January 29, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@bryanchriswhite bryanchriswhite

Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. on-chain On-chain business logic
Projects
Shannon
Status: ✅ Done
Milestone
Beta TestNet Iteration
Development

Successfully merging this pull request may close these issues.

[Morse->Shannon Migration] Migration module
1 participant
@bryanchriswhite