[LocalNet] Run Relayer and AppGateServer #179

okdas · 2023-11-11T17:40:14Z

Summary

Human Summary

As we've got relayer moved from the alpha repo, and appgateserver merged into main, we need to be able to run them on LocalNet. Support for this on helm-charts side have been merged.

AI Summary

Summary generated by Reviewpad on 11 Nov 23 17:40 UTC

This pull request introduces changes related to the relayer and appgateserver.

It adds new values files for the appgateserver and relayer in the localnet/kubernetes directory and sets their enable values to true.

Additionally, it modifies the Tiltfile to include the appgateserver helm resource, which uses the new values file and sets the replicaCount based on the localnet configuration.

Overall, this patch adds support for the appgateserver and enables the relayer in the localnet setup.

Type of change

Select one or more:

Testing

Run all unit tests: make go_develop_and_test
Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

I have tested my changes using the available tooling
I have performed a self-review of my own code
I have commented my code, updated documentation and left TODOs throughout the codebase

Olshansk

This LGTM. @okdas What do you see as the blocking next step to get this in?

bryanchriswhite · 2023-11-14T12:15:35Z

Based on the state of charts/poktroll/templates/scripts.yaml on main, it looks like we still need to:

Update the subcommand name relayer -> relayminer
Decide when/how to workaround or integrate with the solution to the supplier1/app1 vs. supplier2/app2 for the relayminer's and appgate server's signing-key flags, respectively. See #poktroll in discord and #177 comment.
(Optional, based on 2) ensure that the suppler and app both have public keys on chain.

h5law · 2023-11-14T19:45:49Z

Tiltfile

@@ -127,11 +128,23 @@ helm_resource(
    poktroll_chart,
    flags=[
        "--values=./localnet/kubernetes/values-common.yaml",
+        "--values=./localnet/kubernetes/values-relayer.yaml",


Still getting this error with the relayers in tilt. Is it still looking for the old command and not the new one?

I am surprised you still see that, as we no longer have the pocketd binary. Let's circle back to this if you still have that issue once we merge everything.

Confirmed: this would not happen on a PR with relayminer implemented. We just need to merge everything.

h5law

AppGateServer works perfectly in localnet k8s! 🔥 Still not working for me with the relayerminer but once thats done this is gunna be so good!

Olshansk · 2023-11-14T20:06:06Z

localnet/kubernetes/values-relayer.yaml

@@ -0,0 +1,2 @@
+relayer:


Per @bryanchriswhite's comment, we need to rename this to relayminer

Olshansk · 2023-11-14T20:09:51Z

@bryanchriswhite Agreed regarding s/relayer/relayminer in this PR.

Re (2) & (3) - I believe it's outside the scope of this PR and we'll capture it in #180.

okdas · 2023-11-14T21:12:56Z

Per discussion above, I'm going to tweak the helm charts to use relayminer instead of relayer.

okdas · 2023-11-15T00:25:25Z

I ended up splitting helm charts for appgate-server and relayminer - https://github.com/pokt-network/helm-charts/pull/6/files. The services are going to have different configs, ports exposed so it made sense to separate them. Also, this should potentially simplify key management for node runners. We will get to that point in a few weeks. :)

Just need a review on that PR and we should be good.

Olshansk

Left one comment but LGTM otherwise

Olshansk · 2023-11-15T04:00:04Z

Dockerfile.dev

@@ -19,5 +19,7 @@ RUN mv /poktroll/bin/poktrolld /usr/bin/poktrolld

 EXPOSE 8545


NIT: Adding a comment on what each exposed port is used for will go a long way!

@Olshansk these will be changed soon, I'll prepare a doc for us to discuss the configs/ports and dependencies for different actors.

Got it. In that case, please see the suggested comment I left below.

Relayminer doesn't work b/c it is not merged yet.

Dockerfile.dev

Co-authored-by: Daniel Olshansky <[email protected]>

Olshansk

@okdas Anything blocking from getting this in?

okdas · 2023-11-16T01:32:43Z

@okdas Anything blocking from getting this in?

nope, let's get it in!

…relayer_cli * pokt/main: [LocalNet] Run Relayer and AppGateServer (#179) [Relay] E2E Relay Gaps (#177)

…-update * merge/e2e_test/relay_x_relayer_cli: [LocalNet] Run Relayer and AppGateServer (#179) [Relay] E2E Relay Gaps (#177) More tiny comment updates Added a couple more comments Update some comments and TODOs Update the names and references to queryNode/sequencerNode/fullNode etc Update pkg/relayer/cmd/cmd.go [Test] Updating `relay.feature` to run curl command to enable E2E Relay Test (#178) Updated comments for post 177+179 work for okdas Update OpenAPI spec Update .gitignore chore: update comment chore: move shared dependency setup logic to shared pkg chore: cleanup flags and dependencies for appgateserver cmd [Supplier] chore: improve supplier not found error message (#183) [CI] Integrate E2E tests with GitHub CI (#152)

* relayer+appgateserver * switch to the other chart * cleanup * Update Dockerfile.dev Co-authored-by: Daniel Olshansky <[email protected]> --------- Co-authored-by: Daniel Olshansky <[email protected]>

relayer+appgateserver

a7061e6

okdas added this to the Shannon TestNet milestone Nov 11, 2023

okdas self-assigned this Nov 11, 2023

okdas marked this pull request as ready for review November 11, 2023 18:53

Olshansk added the infra Infra or tooling related improvements, additions or fixes label Nov 14, 2023

Olshansk self-requested a review November 14, 2023 04:45

Olshansk reviewed Nov 14, 2023

View reviewed changes

h5law reviewed Nov 14, 2023

View reviewed changes

h5law previously requested changes Nov 14, 2023

View reviewed changes

Olshansk reviewed Nov 14, 2023

View reviewed changes

Olshansk requested a review from bryanchriswhite November 14, 2023 20:06

bryanchriswhite mentioned this pull request Nov 14, 2023

[Relay] E2E Relay Gaps #177

Merged

10 tasks

okdas added 2 commits November 14, 2023 15:10

switch to the other chart

1831575

cleanup

8f8d068

okdas requested a review from Olshansk November 15, 2023 00:22

Merge branch 'main' into appgateserver-localnet

9861e94

Olshansk approved these changes Nov 15, 2023

View reviewed changes

Merge branch 'main' into appgateserver-localnet

2ffce66

Olshansk reviewed Nov 15, 2023

View reviewed changes

Dockerfile.dev Show resolved Hide resolved

Update Dockerfile.dev

74df6da

Co-authored-by: Daniel Olshansky <[email protected]>

Olshansk approved these changes Nov 16, 2023

View reviewed changes

okdas merged commit c08a103 into main Nov 16, 2023
8 checks passed

bryanchriswhite added a commit that referenced this pull request Nov 16, 2023

Merge remote-tracking branch 'pokt/main' into merge/e2e_test/relay_x_…

09de036

…relayer_cli * pokt/main: [LocalNet] Run Relayer and AppGateServer (#179) [Relay] E2E Relay Gaps (#177)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LocalNet] Run Relayer and AppGateServer #179

[LocalNet] Run Relayer and AppGateServer #179

okdas commented Nov 11, 2023 •

edited by reviewpad bot

Loading

Olshansk left a comment

bryanchriswhite commented Nov 14, 2023 •

edited

Loading

h5law Nov 14, 2023

okdas Nov 14, 2023 •

edited

Loading

okdas Nov 15, 2023

h5law left a comment

Olshansk Nov 14, 2023

Olshansk commented Nov 14, 2023

okdas commented Nov 14, 2023

okdas commented Nov 15, 2023

Olshansk left a comment

Olshansk Nov 15, 2023

okdas Nov 15, 2023

Olshansk Nov 15, 2023

Olshansk left a comment

okdas commented Nov 16, 2023

		@@ -19,5 +19,7 @@ RUN mv /poktroll/bin/poktrolld /usr/bin/poktrolld

		EXPOSE 8545

[LocalNet] Run Relayer and AppGateServer #179

[LocalNet] Run Relayer and AppGateServer #179

Conversation

okdas commented Nov 11, 2023 • edited by reviewpad bot Loading

Summary

Human Summary

AI Summary

Summary generated by Reviewpad on 11 Nov 23 17:40 UTC

Type of change

Testing

Sanity Checklist

Olshansk left a comment

Choose a reason for hiding this comment

bryanchriswhite commented Nov 14, 2023 • edited Loading

h5law Nov 14, 2023

Choose a reason for hiding this comment

okdas Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

okdas Nov 15, 2023

Choose a reason for hiding this comment

h5law left a comment

Choose a reason for hiding this comment

Olshansk Nov 14, 2023

Choose a reason for hiding this comment

Olshansk commented Nov 14, 2023

okdas commented Nov 14, 2023

okdas commented Nov 15, 2023

Olshansk left a comment

Choose a reason for hiding this comment

Olshansk Nov 15, 2023

Choose a reason for hiding this comment

okdas Nov 15, 2023

Choose a reason for hiding this comment

Olshansk Nov 15, 2023

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

okdas commented Nov 16, 2023

okdas commented Nov 11, 2023 •

edited by reviewpad bot

Loading

bryanchriswhite commented Nov 14, 2023 •

edited

Loading

okdas Nov 14, 2023 •

edited

Loading