-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Supplier] refactor: supplier module keys #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
on-chain
On-chain business logic
code health
Cleans up some code
labels
Dec 12, 2023
10 tasks
bryanchriswhite
force-pushed
the
issues/141/refactor/claim-proof
branch
from
December 12, 2023 17:09
17e1b7e
to
9a59011
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-keys
branch
from
December 12, 2023 17:09
d5492ed
to
3d97a36
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/claim-proof
branch
from
December 13, 2023 10:52
99fa69b
to
b58e75d
Compare
8 tasks
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-keys
branch
from
December 13, 2023 12:42
3d97a36
to
cd0c4d7
Compare
bryanchriswhite
changed the title
refactor: supplier module keys
[Supplier] refactor: supplier module keys
Dec 13, 2023
bryanchriswhite
force-pushed
the
issues/141/refactor/claim-proof
branch
from
December 13, 2023 14:01
b58e75d
to
d069306
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/claim-proof
branch
from
December 13, 2023 21:00
d069306
to
ef3cd99
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-keys
branch
from
December 13, 2023 21:19
cd0c4d7
to
f509fbf
Compare
h5law
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm nice simplification
Olshansk
approved these changes
Dec 14, 2023
Co-authored-by: harry <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: harry <[email protected]>
…im-proof * pokt/main: Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
This was referenced Dec 22, 2023
…or/supplier-keys * issues/141/refactor/claim-proof: chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
11 tasks
Co-authored-by: Daniel Olshansky <[email protected]>
…im-proof * pokt/main: [Supplier] refactor: claim & proof protobufs + (#263)
bryanchriswhite
changed the base branch from
issues/141/refactor/claim-proof
to
main
January 10, 2024 12:27
bryanchriswhite
added a commit
that referenced
this pull request
Jan 10, 2024
…plier-keys * pokt/main: [Supplier] refactor: supplier module keys (#264)
bryanchriswhite
added a commit
that referenced
this pull request
Jan 10, 2024
…/in-memory-network * issues/141/prep/in-memory-network: [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)
bryanchriswhite
added a commit
that referenced
this pull request
Jan 12, 2024
…ctor/in-memory-network * issues/141/feat/in-memory-network: chore: review feedback improvements feat: update SMT to v0.9.2 (#311) fix: linter errors fixup! chore: review feedback improvements chore: review feedback improvements chore: review feedback improvements [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
* refactor: `NewMinedRelay` to shared testutil * refactor: claim & proof protobuf types * refactor: rename supplier keeper `UpsertClaim` & `UpsertProof` * refactor: misc. claim-side improvements * chore: add TODOs * refactor: supplier module keys * chore: review feedback improvements Co-authored-by: harry <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]> * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: harry <[email protected]> * chore: add TODOs * trigger CI * chore: add TODO * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * fix: usage raw string literal --------- Co-authored-by: harry <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code health
Cleans up some code
on-chain
On-chain business logic
supplier
Changes related to the Supplier actor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Simplifies supplier module composite key generation in preparation for additional usage for proof persistence/retrieval.
Issue
SubmitProof
message handling #141Type of change
Select one or more:
Testing
make go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR. This is VERY expensive, o only do it after all the reviews are complete.Sanity Checklist