Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Supplier] refactor: supplier module keys #264

Merged
merged 26 commits into from
Jan 10, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 12, 2023

Summary

Human Summary

Simplifies supplier module composite key generation in preparation for additional usage for proof persistence/retrieval.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, o only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic code health Cleans up some code labels Dec 12, 2023
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Dec 12, 2023
@bryanchriswhite bryanchriswhite self-assigned this Dec 12, 2023
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from 17e1b7e to 9a59011 Compare December 12, 2023 17:09
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/supplier-keys branch from d5492ed to 3d97a36 Compare December 12, 2023 17:09
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from 99fa69b to b58e75d Compare December 13, 2023 10:52
@bryanchriswhite bryanchriswhite linked an issue Dec 13, 2023 that may be closed by this pull request
8 tasks
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/supplier-keys branch from 3d97a36 to cd0c4d7 Compare December 13, 2023 12:42
@bryanchriswhite bryanchriswhite added the supplier Changes related to the Supplier actor label Dec 13, 2023
@bryanchriswhite bryanchriswhite changed the title refactor: supplier module keys [Supplier] refactor: supplier module keys Dec 13, 2023
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from b58e75d to d069306 Compare December 13, 2023 14:01
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from d069306 to ef3cd99 Compare December 13, 2023 21:00
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/supplier-keys branch from cd0c4d7 to f509fbf Compare December 13, 2023 21:19
@bryanchriswhite bryanchriswhite marked this pull request as ready for review December 13, 2023 21:20
Copy link
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm nice simplification

x/supplier/types/keys.go Show resolved Hide resolved
bryanchriswhite and others added 3 commits December 22, 2023 14:36
Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: harry <[email protected]>
…im-proof

* pokt/main:
  Fix bug introduced by #252 where genesis file was no longer being copied to the right location
  [Docs] Introduce Docusaurus documentation (#252)
  [Cleanup] Centralzie websocket url -> endpoint changes (#272)
  refactor: `NewMinedRelay` to shared testutil (#262)
  fix: PR template typo 2 (#269)
  [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253)
  [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
…im-proof

* pokt/main:
  [Docs] Load Test #1 - Plan (#286)
  [Bug] Fix observable error logging (#298)
  [docs] Relayminer config documentation (#288)
  [Configs] Add foundation for RelayMiner operation configs. (#284)
  [SMT] Update to use SMT v0.8.2 (#297)
  [EventsReplayClient] Fix Replay Client Bugs (#267)
…or/supplier-keys

* issues/141/refactor/claim-proof:
  chore: add TODOs
  [Docs] Load Test #1 - Plan (#286)
  [Bug] Fix observable error logging (#298)
  [docs] Relayminer config documentation (#288)
  [Configs] Add foundation for RelayMiner operation configs. (#284)
  [SMT] Update to use SMT v0.8.2 (#297)
  [EventsReplayClient] Fix Replay Client Bugs (#267)
…im-proof

* pokt/main:
  [SMT] Path Bump to v0.8.2 (#305)
  [Configs] feat: Add stake amount to supplier staking config (#300)
  [Configs] feat: Add stake amount in the app stake config (#299)
…or/supplier-keys

* issues/141/refactor/claim-proof:
  chore: add TODO
  [SMT] Path Bump to v0.8.2 (#305)
  [Configs] feat: Add stake amount to supplier staking config (#300)
  [Configs] feat: Add stake amount in the app stake config (#299)
  trigger CI
@bryanchriswhite bryanchriswhite changed the base branch from issues/141/refactor/claim-proof to main January 10, 2024 12:27
@bryanchriswhite bryanchriswhite merged commit 03ed4b5 into main Jan 10, 2024
5 checks passed
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
…plier-keys

* pokt/main:
  [Supplier] refactor: supplier module keys (#264)
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
…ctor/supplier-errors

* issues/141/refactor/supplier-keys:
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
…ep/in-memory-network

* issues/141/refactor/supplier-errors:
  [Supplier] refactor: supplier module errors (#265)
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
…/in-memory-network

* issues/141/prep/in-memory-network:
  [Testing, Tooling] chore: in-memory network interface & config types (#289)
  trigger CI
  [Supplier] refactor: supplier module errors (#265)
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
  chore: review feedback improvements
  [Configs] feat: Add staking config parser of gateway staking (#302)
  chore: review feedback improvements
  fix: usage raw string literal
  chore: review feedback improvements
  [RingCache] Invalidate Cache On Redelegation Events (#239)
bryanchriswhite added a commit that referenced this pull request Jan 12, 2024
…ctor/in-memory-network

* issues/141/feat/in-memory-network:
  chore: review feedback improvements
  feat: update SMT to v0.9.2 (#311)
  fix: linter errors
  fixup! chore: review feedback improvements
  chore: review feedback improvements
  chore: review feedback improvements
  [Testing, Tooling] chore: in-memory network interface & config types (#289)
  trigger CI
  [Supplier] refactor: supplier module errors (#265)
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
  chore: review feedback improvements
  [Configs] feat: Add staking config parser of gateway staking (#302)
  chore: review feedback improvements
  fix: usage raw string literal
  chore: review feedback improvements
  [RingCache] Invalidate Cache On Redelegation Events (#239)
okdas pushed a commit that referenced this pull request Nov 14, 2024
* refactor: `NewMinedRelay` to shared testutil

* refactor: claim & proof protobuf types

* refactor: rename supplier keeper `UpsertClaim` & `UpsertProof`

* refactor: misc. claim-side improvements

* chore: add TODOs

* refactor: supplier module keys

* chore: review feedback improvements

Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>

* chore: review feedback improvements

Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: harry <[email protected]>

* chore: add TODOs

* trigger CI

* chore: add TODO

* chore: review feedback improvements

Co-authored-by: Daniel Olshansky <[email protected]>

* fix: usage raw string literal

---------

Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code on-chain On-chain business logic supplier Changes related to the Supplier actor
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Protocol] MVP implementation off the on-chain SubmitProof message handling
3 participants