[Tooling] fix: PR template typo 2 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
code health
Olshansk
approved these changes
Dec 13, 2023
h5law
added a commit
that referenced
this pull request
Dec 14, 2023
commit df73cfa Author: Bryan White <[email protected]> Date: Thu Dec 14 01:06:03 2023 +0100 refactor: `NewMinedRelay` to shared testutil (#262) commit 410965a Author: Bryan White <[email protected]> Date: Thu Dec 14 01:05:52 2023 +0100 fix: PR template typo 2 (#269) commit dd7df68 Author: Daniel Olshansky <[email protected]> Date: Wed Dec 13 13:45:26 2023 -0800 [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) This is aiming to fix multiple issues in E2E tests and just general QoL improvements: 1. Adding a comment in `relay.feature` about the need to run `make supplier1_stake && make app1_stake` until we fix #180 (known issue) 2. Replacing the reference to host `sequencer-poktroll-sequencer` with `localhost` (see first screenshot below) 3. Fixed a bug leading us to assert against a `MsgSubmitProof` event instead of a `MsgCreateClaim` event (see second screenshot below) 4. Fixed on-chain logging under `x/*` by replacing `logger\.(Info|Error)\("([^"]+)"(?:, (.*))?\)` with `logger.$1(fmt.Sprintf("$2", $3))` so it works as expected 5. Some quality-of-life comments & TODOs 6. Minor additions to unit tests from #220 commit d621631 Author: Redouane Lakrache <[email protected]> Date: Wed Dec 13 16:24:34 2023 +0100 [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261) * feat: Have distinct JSON-RPC and gRPC urls * chore: Trigger e2e tests * chore: Fix import groups commit 4e30e27 Author: Bryan White <[email protected]> Date: Wed Dec 13 14:28:36 2023 +0100 fix PR template testing checklist item (#268)
okdas
pushed a commit
that referenced
this pull request
Dec 19, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Dec 22, 2023
…im-proof * pokt/main: Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
bryanchriswhite
added a commit
that referenced
this pull request
Dec 22, 2023
…or/supplier-keys * issues/141/refactor/claim-proof: chore: review feedback improvements chore: review feedback improvements Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
bryanchriswhite
added a commit
that referenced
this pull request
Dec 22, 2023
…ctor/supplier-errors * issues/141/refactor/supplier-keys: chore: review feedback improvements chore: review feedback improvements Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
One more typo in the PR template.
Issue
N/A
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, o only do it after all the reviews are complete.Sanity Checklist