[Migration Review - DO NOT MERGE] Gateway module #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
gateway
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
red-0ne
force-pushed
the
migration/review/gateway-module
branch
3 times, most recently
from
fd262a0 to
3407ea5
Compare
ignite scaffold module gateway --dep bank
ignite scaffold map gateway stake:coin --module gateway --no-message --index address --signer address
ignite scaffold message stake_gateway stake:coin --signer address --module gateway
ignite scaffold message unstake_gateway --signer address --module gateway
red-0ne
force-pushed
the
migration/review/gateway-module
branch
from
3407ea5 to
e248711
Compare
11 tasks
Olshansk
requested changes
Feb 13, 2024
| ) | ||
|
|
||
| // AutoCLIOptions implements the autocli.HasAutoCLIConfig interface. | ||
| func (am AppModule) AutoCLIOptions() *autocliv1.ModuleOptions { |
There was a problem hiding this comment.
How does autocli play with the other endpoints initiated?
There was a problem hiding this comment.
Currently autocli is not used to generate or to handle CLI commands. As of my understanding, we will wire it to our commands when it'll be possible to handle configuration files.
|
@Olshansk, I addressed most of the change requests and left a couple of them with comments. PTAL. |
Olshansk
approved these changes
Feb 14, 2024
|
@red-0ne please add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Review branch for the gateway module migration to rollkit/cosmos-sdk v0.50.x (see: migration notion doc).
Once this branch is approved:
git diff origin/migration/gateway-module..origin/migration/review/gateway-moduleNOTE:
*.pulsar.gocode is auto-generated and can be ignoredIssue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist