[Migration Review - DO NOT MERGE] Application module #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignite scaffold module application --dep bank,account,gateway --params max-delegated-gateways:uint
ignite scaffold map application stake:coin service-configs:array.string delegatee-gateway-addresses:array.string --no-message --module application --index address --signer address
ignite scaffold message stake-application stake:coin services:array.string --signer address --module application
ignite scaffold message unstake-application --signer address --module application
ignite scaffold message delegate-to-gateway gateway-address:string --signer app-address --module application
ignite scaffold message undelegate-from-gateway gateway-address:string --signer app-address --module application
red-0ne
added
application
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Olshansk
requested changes
Feb 13, 2024
|
|
||
| // the address capable of executing a MsgUpdateParams message. Typically, this | ||
| // should be the x/gov module account. | ||
| authority string | ||
|
|
||
| bankKeeper types.BankKeeper |
There was a problem hiding this comment.
Can we use ModuleInputs for this instead?
There was a problem hiding this comment.
This whole file is a scaffold by ignite scaffold module application --dep bank,account,gateway. We didn't altere it and should be kept that way IMO.
Also ModuleInputs has public properties, while the Keeper struct has them private.
|
@red-0ne please add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Review branch for the application module migration to rollkit/cosmos-sdk v0.50.x (see: migration notion doc).
Once this branch is approved, review and merge #378
NOTE:
*.pulsar.gocode is auto-generated and can be ignoredIssue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist