-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update Quickstart
guide to onboard new devs
#501
Conversation
Quickstart
guide to onboard new devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great guide, left a couple of comments but should not affect the quickstart story.
@@ -15,5 +15,5 @@ services: | |||
rpc_type: JSON_RPC | |||
- service_id: ollama | |||
endpoints: | |||
- publicly_exposed_url: http://relayminer1:8545 | |||
- publicly_exposed_url: http://relayminer2:8545 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is intended to be a working (non-kubernetes) example, so maybe it should remain relayminer1
@@ -1,19 +1,19 @@ | |||
signing_key_name: supplier1 | |||
signing_key_name: shannon_supplier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure shannon_supplier
signing key name exists in config.yml
and that it has a stake target in Makefile
…cept * pokt/main: Reply to red0ne's comments's in https://github.com/pokt-network/poktroll/pull/501\#pullrequestreview-2047120225 [Docs] Added QuickStart video (#522) [Genesis Config] Set MaxValidators to 1 (#520) [Docs] Update `Quickstart` guide to onboard new devs (#501) [Code Health] chore: cleanup localnet testutils (#515) Zero retryLimit Support in ReplayClient (#442)
Update the Quickstar guide to enable anyone to start developing on LocalNet quickly.
Summary
Update the Quickstar guide to enable anyone to start developing on LocalNet quickly.
Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist