Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Team's Iteration16 TODO preparation #577

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Jun 4, 2024

Go through ALMOST all the TODOs and and to the following:

  • Add an owner where applicable
  • Mark things as TODO_BLOCKER if they need to be done in iteration [Testing] E2E Testing Framework #16
  • Mark things as TODO_BETA if they are needed for the beta launch
  • Mark things as TODO_MAINNET if they are needed for mainnet

This enables generating a TODO list like so:

grep -r "TODO_BLOCKER(@Olshansk)" . | sed 's/^/- [ ] `/' | sed 's/:/`:/'

@Olshansk Olshansk added the documentation Improvements or additions to documentation label Jun 4, 2024
@Olshansk Olshansk self-assigned this Jun 4, 2024
@Olshansk Olshansk added this to the Shannon Beta TestNet Launch milestone Jun 4, 2024
@Olshansk Olshansk marked this pull request as ready for review June 4, 2024 04:17
@Olshansk Olshansk changed the title [TODO] @Olshank's Iteration16 TODO preparation [TODO] Team's Iteration16 TODO preparation Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 577)
Grafana network dashboard for devnet-issue-{issue-id}

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jun 4, 2024
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge it.

Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going through all the TODOs.

I double-checked to-dos assigned to me - they do make sense, but a few seem already resolved. I'll clean them up in #587.

@Olshansk Olshansk merged commit aa61236 into main Jun 5, 2024
12 checks passed
@Olshansk Olshansk deleted the olshansky_iteration16_blocker branch June 5, 2024 03:47
bryanchriswhite added a commit that referenced this pull request Jun 5, 2024
…n-claim-window

* pokt/main:
  [TODO] Team's Iteration16 TODO preparation (#577)
  Updated go.sum & go.mod
  [Tooling] Updated Makefile target for Grove gateway (#575)
  [Ring] Replace `noot/ring-go` with `pokt-network/ring-go` (#563)
  [On-chain] feat: add `claim_window_close_offset_blocks` shared module param (#568)
bryanchriswhite added a commit that referenced this pull request Jun 5, 2024
…indow-open-offset-blocks

* pokt/main:
  [TODO] Team's Iteration16 TODO preparation (#577)
  Updated go.sum & go.mod
  [Tooling] Updated Makefile target for Grove gateway (#575)
  [Ring] Replace `noot/ring-go` with `pokt-network/ring-go` (#563)
bryanchriswhite added a commit that referenced this pull request Jun 5, 2024
…ssues/516/feat/proof-window-close-offset-blocks

* issues/516/feat/proof-window-open-offset-blocks:
  chore: update comments
  [TODO] Team's Iteration16 TODO preparation (#577)
  Updated go.sum & go.mod
  [Tooling] Updated Makefile target for Grove gateway (#575)
  [Ring] Replace `noot/ring-go` with `pokt-network/ring-go` (#563)
  [On-chain] feat: add `claim_window_close_offset_blocks` shared module param (#568)
  chore: add param update make target
  Empty commit
  [Relayminer] refactor: relayminer to use `claim_window_open_offset_blocks` shared param (#565)
  [Claim/proof] feat: add `claim_window_open_offset_blocks` shared module param (#561)
  Empty commit
  chore: self-review improvements
okdas pushed a commit that referenced this pull request Nov 14, 2024
Go through ALMOST all the TODOs and and to the following:

- Add an owner where applicable
- Mark things as `TODO_BLOCKER` if they need to be done in iteration #16
- Mark things as `TODO_BETA` if they are needed for the beta launch
- Mark things as `TODO_MAINNET` if they are needed for mainnet

This enables generating a TODO list like so:

```
grep -r "TODO_BLOCKER(@Olshansk)" . | sed 's/^/- [ ] `/' | sed 's/:/`:/'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e documentation Improvements or additions to documentation push-image CI related - pushes images to ghcr.io
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants