-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO] Team's Iteration16 TODO preparation #577
Conversation
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 577) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for going through all the TODOs.
I double-checked to-dos assigned to me - they do make sense, but a few seem already resolved. I'll clean them up in #587.
…n-claim-window * pokt/main: [TODO] Team's Iteration16 TODO preparation (#577) Updated go.sum & go.mod [Tooling] Updated Makefile target for Grove gateway (#575) [Ring] Replace `noot/ring-go` with `pokt-network/ring-go` (#563) [On-chain] feat: add `claim_window_close_offset_blocks` shared module param (#568)
…ssues/516/feat/proof-window-close-offset-blocks * issues/516/feat/proof-window-open-offset-blocks: chore: update comments [TODO] Team's Iteration16 TODO preparation (#577) Updated go.sum & go.mod [Tooling] Updated Makefile target for Grove gateway (#575) [Ring] Replace `noot/ring-go` with `pokt-network/ring-go` (#563) [On-chain] feat: add `claim_window_close_offset_blocks` shared module param (#568) chore: add param update make target Empty commit [Relayminer] refactor: relayminer to use `claim_window_open_offset_blocks` shared param (#565) [Claim/proof] feat: add `claim_window_open_offset_blocks` shared module param (#561) Empty commit chore: self-review improvements
Go through ALMOST all the TODOs and and to the following: - Add an owner where applicable - Mark things as `TODO_BLOCKER` if they need to be done in iteration #16 - Mark things as `TODO_BETA` if they are needed for the beta launch - Mark things as `TODO_MAINNET` if they are needed for mainnet This enables generating a TODO list like so: ``` grep -r "TODO_BLOCKER(@Olshansk)" . | sed 's/^/- [ ] `/' | sed 's/:/`:/' ```
Go through ALMOST all the TODOs and and to the following:
TODO_BLOCKER
if they need to be done in iteration [Testing] E2E Testing Framework #16TODO_BETA
if they are needed for the beta launchTODO_MAINNET
if they are needed for mainnetThis enables generating a TODO list like so: