[Proof Module] Add proof_requirement_threshold param
#595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
…param/proof_request_probability
…param/proof_request_probability
bryanchriswhite
added
on-chain
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 595) |
|
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
bryanchriswhite
commented
Jun 7, 2024
bryanchriswhite
commented
Jun 7, 2024
bryanchriswhite
commented
Jun 7, 2024
bryanchriswhite
force-pushed
the
issues/579/param/proof_requirement_threshold
branch
from
f59a006 to
60c6de8
Compare
bryanchriswhite
force-pushed
the
issues/579/param/proof_requirement_threshold
branch
from
60c6de8 to
a4f6ac0
Compare
…request_probability * pokt/main: [Proof Module] feat: on-chain proof window validation (#588)
…/579/param/proof_requirement_threshold
bryanchriswhite
changed the base branch from
issues/579/param/proof_request_probability
to
main
…requirement_threshold * pokt/main: [Proof Module] Add `proof_request_probability` param (#593)
8 tasks
bryanchriswhite
commented
Jun 7, 2024
Olshansk
changed the title
proof_requirement_threshold param
Olshansk
approved these changes
Jun 10, 2024
| @@ -24,8 +24,8 @@ func TestParams_ValidateMinRelayDifficulty(t *testing.T) { | |||
| }{ | |||
| { | |||
| desc: "invalid type", | |||
There was a problem hiding this comment.
invalid type or invalid value?
There was a problem hiding this comment.
Invalid type. It should be a uint64 but this test case uses int64.
|
Bypassing failing E2E tests, which passed in 151c4e3. Subsequent commits don't modify any code. |
8 tasks
bryanchriswhite
added a commit
that referenced
this pull request
Jun 12, 2024
…missing_penalty * pokt/main: [Proof Module] Add `proof_requirement_threshold` param (#595)
bryanchriswhite
added a commit
that referenced
this pull request
Jun 13, 2024
…accounts' into issues/579/test/tokenomics-keeper * pokt/issues/579/refactor/pre-generated-accounts: chore: review feedback improvements [Proof Module] Add `proof_requirement_threshold` param (#595) chore: review improvements refactor: proof_missing_penalty to cosmos.base.v1beta1.Coin type Empty commit fix: keyring.Keyring#NewAccount() arg ordering [Grafana] Improve grafana in preparation for relay mining stress test (#599) [Relay Mining] Foundation for integration test helpers + start integrating Relay Mining into EndBlocker (#571) chore: update yarn.lock docs: add adding on-chain params page chore: self-review chore: review
bryanchriswhite
added a commit
that referenced
this pull request
Jun 13, 2024
…/probabilistic-proofs * issues/579/test/tokenomics-keeper: chore: review improvements chore: review feedback improvements [Proof Module] Add `proof_requirement_threshold` param (#595) chore: review improvements refactor: proof_missing_penalty to cosmos.base.v1beta1.Coin type Empty commit fix: keyring.Keyring#NewAccount() arg ordering [Grafana] Improve grafana in preparation for relay mining stress test (#599) [Relay Mining] Foundation for integration test helpers + start integrating Relay Mining into EndBlocker (#571) chore: update yarn.lock docs: add adding on-chain params page chore: self-review chore: review
bryanchriswhite
added a commit
that referenced
this pull request
Jun 13, 2024
…hore/telemetry * issues/579/feat/probabilistic-proofs: chore: post-merge cleanup chore: review improvements chore: review feedback improvements fix: failing CI unit test test: add coverage for tokenomicstypes.Keeper#isProofRequired() fix: use seeded deterministic PRNG [Proof Module] Add `proof_requirement_threshold` param (#595) chore: review improvements refactor: proof_missing_penalty to cosmos.base.v1beta1.Coin type Empty commit fix: keyring.Keyring#NewAccount() arg ordering [Grafana] Improve grafana in preparation for relay mining stress test (#599) [Relay Mining] Foundation for integration test helpers + start integrating Relay Mining into EndBlocker (#571) chore: update yarn.lock docs: add adding on-chain params page chore: self-review chore: review
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
proof_requirement_thresholdparam to theproofmodule.Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist