Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LocalNet] Switch to CosmosSDK defaults #609

Merged
merged 10 commits into from
Jun 21, 2024
Merged

Conversation

okdas
Copy link
Member

@okdas okdas commented Jun 15, 2024

Summary

To avoid confusion about different ports we expose on multiple processes - let's stick to the defaults provided by cosmos sdk.

Also requires a change in helm-charts: pokt-network/helm-charts#37.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the code health Cleans up some code label Jun 15, 2024
@okdas okdas added this to the Shannon Beta TestNet Launch milestone Jun 15, 2024
@okdas okdas self-assigned this Jun 15, 2024
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 609)
Grafana network dashboard for devnet-issue-{issue-id}

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jun 17, 2024
@okdas okdas marked this pull request as ready for review June 17, 2024 23:19
@okdas okdas marked this pull request as draft June 17, 2024 23:37
@okdas okdas marked this pull request as ready for review June 18, 2024 00:03
@okdas okdas requested a review from Olshansk June 18, 2024 00:03
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okdas LGTM but please make sure a local stress test works before merging.

@okdas okdas merged commit b0b25e8 into main Jun 21, 2024
12 checks passed
bryanchriswhite added a commit that referenced this pull request Jun 26, 2024
…02/refactor/relayminer

* pokt/issues/402/feat/rng:
  [Code Health] refactor: tx hash encoding (#617)
  [Docs] Relay session & claim/proof diagrams (#478)
  Empty commit
  [Code Health] refactor: block query client interface (#616)
  [TODO] chore: cleanup done TODOs (#627)
  [TODOs] chore: cleanup validate session ID TODOs (#608)
  [LocalNet] Switch to CosmosSDK defaults (#609)
  [Relay Mining] Emit events and refactor test helpers (#610)
  [Docs] Minor improvements to `adding_params.md` (#623)
  [Telemetry] chore: add probabilistic proof telemetry (#605)
bryanchriswhite added a commit that referenced this pull request Jun 27, 2024
…aim-proof-distribution

* issues/402/refactor/relayminer: (21 commits)
  fix: unflake and speed up tests
  chore: speed up & improve tests
  chore: update comments
  chore: simplify
  [E2E] Add logging output from the init-container step (#635)
  fix: failing test
  Empty commit
  [Code Health] refactor: random number generation (#618)
  chore: review improvements
  chore: review improvments
  [Code Health] refactor: tx hash encoding (#617)
  [Docs] Relay session & claim/proof diagrams (#478)
  Empty commit
  [Code Health] refactor: block query client interface (#616)
  chore: review feedback improvements
  [TODO] chore: cleanup done TODOs (#627)
  [TODOs] chore: cleanup validate session ID TODOs (#608)
  [LocalNet] Switch to CosmosSDK defaults (#609)
  [Relay Mining] Emit events and refactor test helpers (#610)
  [Docs] Minor improvements to `adding_params.md` (#623)
  ...
okdas added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants