[Docs] Minor improvements to adding_params.md
#623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
requested changes
Jun 19, 2024
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Bryan White <[email protected]>
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 623) |
github-actions
bot
added
devnet
push-image
There was a problem hiding this comment.
I added some suggestions for a bit more detail in a few places. I just dog-fooded this while putting #628 together and found some missing steps. 🦾
bryanchriswhite
added a commit
that referenced
this pull request
Jun 26, 2024
…02/refactor/relayminer * pokt/issues/402/feat/rng: [Code Health] refactor: tx hash encoding (#617) [Docs] Relay session & claim/proof diagrams (#478) Empty commit [Code Health] refactor: block query client interface (#616) [TODO] chore: cleanup done TODOs (#627) [TODOs] chore: cleanup validate session ID TODOs (#608) [LocalNet] Switch to CosmosSDK defaults (#609) [Relay Mining] Emit events and refactor test helpers (#610) [Docs] Minor improvements to `adding_params.md` (#623) [Telemetry] chore: add probabilistic proof telemetry (#605)
bryanchriswhite
added a commit
that referenced
this pull request
Jun 27, 2024
…aim-proof-distribution * issues/402/refactor/relayminer: (21 commits) fix: unflake and speed up tests chore: speed up & improve tests chore: update comments chore: simplify [E2E] Add logging output from the init-container step (#635) fix: failing test Empty commit [Code Health] refactor: random number generation (#618) chore: review improvements chore: review improvments [Code Health] refactor: tx hash encoding (#617) [Docs] Relay session & claim/proof diagrams (#478) Empty commit [Code Health] refactor: block query client interface (#616) chore: review feedback improvements [TODO] chore: cleanup done TODOs (#627) [TODOs] chore: cleanup validate session ID TODOs (#608) [LocalNet] Switch to CosmosSDK defaults (#609) [Relay Mining] Emit events and refactor test helpers (#610) [Docs] Minor improvements to `adding_params.md` (#623) ...
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
The [default list](https://github.com/FormidableLabs/prism-react-renderer/blob/master/packages/generate-prism-languages/index.ts#L9-L23) of docusaurus syntax highlighting did not include some (e.g. `makefile`, `gherkin`, `json`) languages that we are using. These are available in the [complete list](https://prismjs.com/#supported-languages) but simply had to be enabled in the [config](https://docusaurus.io/docs/next/markdown-features/code-blocks#supported-languages). Also, minor edits & nits for readability. Co-authored-by: Bryan White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default list of docusaurus syntax highlighting did not include some (e.g.
makefile,gherkin,json) languages that we are using.These are available in the complete list but simply had to be enabled in the config.
Also, minor edits & nits for readability.
Type of change
Select one or more:
Testing
make docusaurus_start; only needed if you make doc changes