-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relayminer] fix: relayminer wait log #645
Conversation
WalkthroughThe change revolves around renaming the constant Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pkg/relayer/proxy/server_builder.go (2 hunks)
Additional comments not posted (2)
pkg/relayer/proxy/server_builder.go (2)
18-22
: LGTM! Improved naming convention.Renaming
supplierStakeWaitTimeSeconds
tosupplierStakeWaitTime
improves readability and consistency.
165-168
: LGTM! Fixed incorrect logging of wait times.The log message now correctly displays a wait time of 1 second instead of 1,000,000,000 seconds.
Summary
Issue
Observation made while working on #644
Before:
After:
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist
Summary by CodeRabbit
supplierStakeWaitTimeSeconds
tosupplierStakeWaitTime
to improve clarity in timing behavior for supplier staking.