Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relayminer] fix: relayminer wait log #645

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Jul 2, 2024

Summary

Issue

Observation made while working on #644

Before:

{"level":"info","message":"Waiting 1000000000 seconds for the supplier with address pokt1re27pw4llwnatx4sq7rlggqzcm6j3f39epq2wa to stake"}

After:

{"level":"info","message":"Waiting 1 seconds for the supplier with address pokt1re27pw4llwnatx4sq7rlggqzcm6j3f39epq2wa to stake"}

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

Summary by CodeRabbit

  • Refactor
    • Renamed supplierStakeWaitTimeSeconds to supplierStakeWaitTime to improve clarity in timing behavior for supplier staking.

@bryanchriswhite bryanchriswhite added the relayminer Changes related to the Relayminer label Jul 2, 2024
@bryanchriswhite bryanchriswhite added this to the Shannon MainNet milestone Jul 2, 2024
@bryanchriswhite bryanchriswhite self-assigned this Jul 2, 2024
Copy link

coderabbitai bot commented Jul 2, 2024

Walkthrough

The change revolves around renaming the constant supplierStakeWaitTimeSeconds to supplierStakeWaitTime and updating its usage within the relayerProxy struct in the server_builder.go file. This change affects the timing mechanism used for waiting for a supplier to be staked, simplifying and making the naming more intuitive.

Changes

File Path Change Summary
pkg/relayer/proxy/server_builder.go Renamed supplierStakeWaitTimeSeconds to supplierStakeWaitTime and updated its usage accordingly.

Poem

🐇 "In the code's vast sea so wide,
Supplier's wait no more to hide,
Time renamed, efficiency displayed,
In concise paths, our journey's laid.
A name polished, clear as day,
With elegance, we now relay." 🌟


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bryanchriswhite bryanchriswhite marked this pull request as ready for review July 2, 2024 08:49
@bryanchriswhite bryanchriswhite requested review from red-0ne and okdas July 2, 2024 08:49
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8593170 and f1b8753.

Files selected for processing (1)
  • pkg/relayer/proxy/server_builder.go (2 hunks)
Additional comments not posted (2)
pkg/relayer/proxy/server_builder.go (2)

18-22: LGTM! Improved naming convention.

Renaming supplierStakeWaitTimeSeconds to supplierStakeWaitTime improves readability and consistency.


165-168: LGTM! Fixed incorrect logging of wait times.

The log message now correctly displays a wait time of 1 second instead of 1,000,000,000 seconds.

@bryanchriswhite bryanchriswhite merged commit aec367e into main Jul 2, 2024
11 checks passed
@bryanchriswhite bryanchriswhite deleted the fix/relayminer/wait-log branch July 2, 2024 09:23
bryanchriswhite added a commit that referenced this pull request Jul 4, 2024
…lays

* pokt/main:
  Tiny: updating labels in tiltfile
  [Load Testing] fix: relay stress test duration calculation (#651)
  [LocalNet] Grafana stress test dashboard changes (#641)
  [Relayminer] fix: relayminer wait log (#645)
okdas pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relayminer Changes related to the Relayminer
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants