Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Full Node Documentation Update (#941 followup) #981

Merged
merged 32 commits into from
Dec 5, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Dec 4, 2024

Summary

  • Improvements to the Full Node walkthrough + cheatsheet
  • A handful of other miscleanious changes to make the docs more "holistic"
  • Prep for the validator cheatsheets

Issue

Type of change

Select one or more from the following:

@Olshansk Olshansk changed the title [Docs] Full Node Documentation Update [Docs] Full Node Documentation Update (#941 followup) Dec 4, 2024
@Olshansk Olshansk self-assigned this Dec 4, 2024
@Olshansk Olshansk requested review from red-0ne and okdas December 4, 2024 03:37
@Olshansk Olshansk added the documentation Improvements or additions to documentation label Dec 4, 2024
@Olshansk Olshansk marked this pull request as ready for review December 4, 2024 03:39
@Olshansk Olshansk added this to the Shannon Beta TestNet Support milestone Dec 4, 2024
Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I haven't run the new script yet, but I'll be going to go through all of them again soon.

Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great full node documentation 🌝

Got a handful of change requests but nothing blocking merging.

Preemptively approving.

@Olshansk Olshansk merged commit 4865278 into main Dec 5, 2024
12 of 13 checks passed
Olshansk added a commit that referenced this pull request Dec 5, 2024
## Summary

Update the full node walkthrough to show how to export port `26656`

## Issue

- #981

## Type of change

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [x] Documentation
- [ ] Other (specify)

## Testing

- [x] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [ ] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

---------

Co-authored-by: Dima K. <[email protected]>
bryanchriswhite added a commit that referenced this pull request Dec 9, 2024
* pokt/main: (22 commits)
  [Docs] How do I access my CometBFT endpoint externally? (#986)
  [Docs] Full Node Documentation Update (#941 followup) (#981)
  Comment ou tthe sed check
  [Application] Support filtering apps by delegatee gateway address (#957)
  [Docs] Add PATH gateway cheat sheet (#964)
  [Docs] Fix Docker Walkthrough gateway container name and add supplier staking note (#939)
  [Bug, Testing] fix: app transfer module-integration test (#980)
  [Tokenomics] refactor: `GlobalInflationPerClaim` var usage to param usage (#953)
  feat: add global_inflation_per_claim param to tokenomics module (#951)
  [Bug, Tooling] fix: app/gateway/supplier stake/unstake make targets (#978)
  [Supplier] refactor: `SupplierStakingFee` var usage to param usage (#948)
  chore: add localnet_config option to disable hot-reloading (#979)
  [Code Health] fix: tokenomics module gRPC return errors (#963)
  [Code Health] fix: supplier module gRPC return errors (#962)
  [Supplier] feat: add `staking_fee` param to supplier module (#944)
  [Code Health] fix: application module gRPC status error returns (#954)
  [Code Health] fix: shared module gRPC return errors (#961)
  [Code Health] fix: session module gRPC status return errors (#960)
  [Code Health] fix: service module gRPC status error returns (#959)
  [Code Health] fix: proof module gRPC status error returns (#956)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants