Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Makefile to use localhost in the default pocket node URL #992

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Dec 11, 2024

Summary

Update the Makefile to use localhost in the default pocket node URL.

Issue

Using the loopback address 127.0.0.1 instead of localhost results in an error when sending TXs on some LocalNet setups:

e.g.:

poktrolld tx bank send $addr $PNF_ADDRESS 1000upokt --yes --home=${POKTROLLD_HOME} --node=${POCKET_NODE}

Results in the following error:

rpc error: code = InvalidArgument desc = invalid Bech32 prefix; expected cosmos, got pokt: invalid request

This also breaks E2E tests as acc_initialize_pubkeys Makefile target used in the E2E tests runs commands similar to the above to fund the accounts.

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@adshmh adshmh added the infra Infra or tooling related improvements, additions or fixes label Dec 11, 2024
@adshmh adshmh added this to the Shannon Beta TestNet Support milestone Dec 11, 2024
@adshmh adshmh requested a review from okdas December 11, 2024 15:04
@adshmh adshmh self-assigned this Dec 11, 2024
Makefile Outdated Show resolved Hide resolved
Co-authored-by: Daniel Olshansky <[email protected]>
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 992)
Grafana network dashboard for devnet-issue-992

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jan 13, 2025
@Olshansk Olshansk assigned Olshansk and unassigned adshmh Jan 21, 2025
@Olshansk
Copy link
Member

@adshmh Do you think this is still needed? If not, let's close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e infra Infra or tooling related improvements, additions or fixes push-image CI related - pushes images to ghcr.io
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants