fix: Incorrect output type for map_groups returning all-NULL column
#20743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
force-pushed
the
agg-returns-scalar-all-null
branch
from
ed7a893 to
088eef7
Compare
|
The tests are my bad. A rebase should help. |
nameexhaustion
force-pushed
the
agg-returns-scalar-all-null
branch
from
04c04be to
57922f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20743 +/- ##
=======================================
Coverage 79.72% 79.73%
=======================================
Files 1561 1561
Lines 221908 221912 +4
Branches 2530 2530
=======================================
+ Hits 176915 176938 +23
+ Misses 44411 44392 -19
Partials 582 582 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15260
Fixes #15260