Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Add frame-level all_horizontal / any_horizontal #20790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hericks
Copy link

@hericks hericks commented Jan 18, 2025

Addresses #20718 .

I didn't add any tests as the implementation simply relies on polars.all_horizontal / polars.any_horizontal, which are already covered by existing tests (similar to the testing of polars.DataFrame.min_horizontal, polars.DataFrame.mean_horizontal, polars.DataFrame.max_horizontal).

The issue is not yet marked as accepted, but I thought it'd be simple enough to implement without too much risk of unnecessary work. Feel free to close if the API shouldn't be adapted as proposed.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (d9f3e3d) to head (eed1359).
Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20790      +/-   ##
==========================================
- Coverage   79.78%   79.78%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      221982   221986       +4     
  Branches     2531     2531              
==========================================
- Hits       177107   177101       -6     
- Misses      44293    44303      +10     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant