Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEM COIN REGISTRY #154

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

GEM COIN REGISTRY #154

wants to merge 9 commits into from

Conversation

GEMzeitgeist
Copy link

GEM COIN REGISTRY

@GEMzeitgeist GEMzeitgeist reopened this Feb 10, 2025
@GEMzeitgeist GEMzeitgeist marked this pull request as draft February 10, 2025 10:08
@GEMzeitgeist GEMzeitgeist marked this pull request as ready for review February 10, 2025 10:09
@GEMzeitgeist GEMzeitgeist marked this pull request as draft February 10, 2025 10:13
@GEMzeitgeist GEMzeitgeist marked this pull request as ready for review February 10, 2025 10:14
@GEMzeitgeist
Copy link
Author

Requesting approval for the pull request review.

odiinnn
odiinnn requested changes Feb 11, 2025
View reviewed changes
gemlogo.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this logo from the root of the registry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

extg5
extg5 reviewed Feb 12, 2025
View reviewed changes
src/coins.json Outdated
Comment on lines 1698 to 1699
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},

extg5
extg5 reviewed Feb 12, 2025
View reviewed changes
src/coins.json Outdated
"order": 1,
"logo_url": "https://github.com/GEMzeitgeist/coins-registry/blob/7f25d8c98ce8025052700bc908ef5e3c6fa698b3/src/coins-logos/GEM_icon.png"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

extg5
extg5 reviewed Feb 12, 2025
View reviewed changes
src/pools.json Outdated
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

extg5
extg5 requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@extg5 extg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid json and wrong url

extg5
extg5 requested changes Feb 12, 2025
View reviewed changes
@GEMzeitgeist
Copy link
Author

In this situation, could you clarify where exactly the logo needs to be updated?
gem_capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extg5 extg5 Awaiting requested review from extg5

@odiinnn odiinnn Awaiting requested review from odiinnn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GEMzeitgeist @odiinnn @extg5